[5.5] Clear CountQuery "select" bindings since we're overriding the columns anyway #21468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 29, 2017
This was referenced Sep 30, 2017
michaeltintiuc
pushed a commit
to michaeltintiuc/framework
that referenced
this pull request
Oct 2, 2017
…olumns anyway (laravel#21468) * update test * handle withCount edge case * fix style * fix style
edmandiesamonte
added a commit
to edmandiesamonte/framework
that referenced
this pull request
Oct 2, 2017
* upstream/5.5: (84 commits) Correct docBlock depenency on syncWithoutDetaching (laravel#21478) update v5.5 changelog allow to specify the queue while scheduling of queued jobs (laravel#21473) [5.5] Clear CountQuery "select" bindings since we're overriding the columns anyway (laravel#21468) add interface access pivot on resource update v5.5 changelog extract trait Fix docblock in Route (laravel#21454) fix test formatting Fix Relation::morphMap() merge (issue laravel#21457). (laravel#21458) extract AnonymousResourceCollection into class to allow serialization revert relationship limits Fix spelling of 'optionally' [5.5] Fix Collection::contains() when the found value is null (laravel#21442) Allow passing a callback to "with" (laravel#21445) [5.5] Add relation and model attributes in RelationNotFoundException (laravel#21426) [5.5] Make sure sql for virtual columns is added after the unsigned modifier (laravel#21441) vendor:publish options alphabetized (laravel#21412) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're overriding the columns in the subquery with
new Expression('count(*)'), in this PR we clear the select bindings since the query won't have the original selects.In reference to: #21464
In reference to: #21465