Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CheckoutBuilder.php #1588

Closed
wants to merge 1 commit into from
Closed

Update CheckoutBuilder.php #1588

wants to merge 1 commit into from

Conversation

Ronan-Lenor
Copy link
Contributor

regarding : #1585

in addition of : #1586

(with script style compliance)

@Ronan-Lenor
Update CheckoutBuilder.php
5009078 
regarding : #1585

in addition of : #1586

(with script style compliance)
@victoralbino victoralbino mentioned this pull request Oct 25, 2023
Closed
@taylorotwell taylorotwell marked this pull request as draft October 25, 2023 14:25
@Ronan-Lenor
Copy link
Contributor Author

Ronan-Lenor commented Oct 25, 2023 •
edited
Loading

the most recent script is better than my solution given 1 hour ago.

'tax_id_collection' => (Cashier::$calculatesTaxes ?: $this->collectTaxIds) ? ['enabled' => true] : [],
nice 👍

@Ronan-Lenor Ronan-Lenor deleted the patch-2 branch October 25, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints Awaiting requested review from driesvints

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ronan-Lenor