Bug 1585 - Tax ID collection requires updating business name on the customer

[stevebauman]

Closes #1585

This PR resolves an issue that appears to have been introduced from a Stripe 2023-10-16 API update, where only the existence of the tax_id_collection.enabled parameter requires the addition of the customer_update parameters, rather than being able to set it to false as it was previously, resulting in the exception:

Stripe\Exception\InvalidRequestException

Tax ID collection requires updating business name on the customer. To enable tax ID collection for an existing customer, please set `customer_update[name]` to `auto`.

The tax_id_collection collection parameter will now be completely omitted when auto-calculation of taxes is disabled.

[stevebauman]

Discovered that this condition previously didn't evaluate correctly without parenthesis, as the null coalescing operator ?? has a lower precedence than the && operator, so the condition is equivalent to:

(isset($data['customer']) && $data['tax_id_collection']['enabled']) ?? false

[driesvints]

Thanks @stevebauman!

[maskeynihal]

Thanks @stevebauman for the fix.

[novaylt123]

This should've been in an announcement. I wasn't aware some of my projects were broken on Stripe side of things.
But thanks for the fix team.

[driesvints]

@novaylt123 I still need to do a more thorough investigation but I'm not sure why things suddenly broke at all. Cashier right now doesn't supports 2023-10-16 as it's pinned to 2022-11-15: https://github.com/laravel/cashier-stripe/blob/14.x/src/Cashier.php#L28

So I want to know why and how this API update affects Cashier at all.

[driesvints]

So Stripe got back to me and confirmed this was a breaking change in test mode only as they were trying some things out. Nothing got broken in production and they've reverted the change since.

[stevebauman]

Thanks for getting to the bottom of it @driesvints! 🙏