-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major overhaul for a possible 4.x release, twilio/sdk 8.x #148
Conversation
Add enabled config
Enable overriding the Twilio message source
Updated CI workflow (while testing is still greatly broken)
Updated CHANGELOG
Rebrand to onlime/laravel-twilio
Happy to merge this, will review in the next few days. If you'd like I can add you as a maintainer of the package also so you can manage? |
Oh, very glad to hear from you. Yes, please do so. I have already published my own fork under Please add me as maintainer. If we can get this back in shape and I don't need to support legacy Laravel/PHP versions, I'd love to continue maintaining it. |
@onlime you have beed added as a maintainer. Feel free to drop support for all old version, no issues. |
…tion-channels/twilio
Would love to see this get merged! |
yes, give @atymic some more time to review it. if not done by the very end of the week, I'm going to merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go. You can approve and merge further changes without me :)
As this project seems quite abandoned, I decided to go the opinionated way and updated the following (see CHANGELOG):
twilio/sdk
to 8.3TWILIO_ENABLED
) to disable the channel Add enabled config #121To the maintainers: Thanks for the great work! Please keep this package in shape and try to integrate at least some of the above, updating
twilio/sdk
to 8.x (see #145).If the package no longer gets any love here, I will publish it under a different (shorter) name
onlime/laravel-twilio
and try to do my best maintaining it. I am not an experienced package maintainer, and I am only using Twilio sparingly in my projects, just for simple SMS notifications. Also, I would only support Laravel 11+.