Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable overriding the Twilio message source #142

Merged

Conversation

misenhower
Copy link

Hey there. This PR adds a new overridable getMessage() method to TwilioChannel. This makes it a lot easier to use a notification method named something other than toTwilio when subclassing TwilioChannel.

Background: I need to send both SMS and voice messages from a single notification (similar to #97). This PR would make it a lot easier for me to create e.g. a TwilioSmsChannel class that calls ->toTwilioSms() on the notification, and a TwilioVoiceChannel class that calls ->toTwilioVoice(). That way I'll be able to use both TwilioSmsChannel and TwilioVoiceChannel in the same notification class.

I wanted to keep this PR simple, but let me know if you want me to add these TwilioSmsChannel/TwilioVoiceChannel classes here as well.

Thanks!!

@misenhower
Copy link
Author

Hey @atymic! Just a friendly ping for this one 😃 Would love to get this merged if possible!

@masterbater
Copy link

Would like this to get merge, but copying the class and renaming the class seem work ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants