Enable overriding the Twilio message source #142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there. This PR adds a new overridable
getMessage()
method toTwilioChannel
. This makes it a lot easier to use a notification method named something other thantoTwilio
when subclassingTwilioChannel
.Background: I need to send both SMS and voice messages from a single notification (similar to #97). This PR would make it a lot easier for me to create e.g. a
TwilioSmsChannel
class that calls->toTwilioSms()
on the notification, and aTwilioVoiceChannel
class that calls->toTwilioVoice()
. That way I'll be able to use bothTwilioSmsChannel
andTwilioVoiceChannel
in the same notification class.I wanted to keep this PR simple, but let me know if you want me to add these
TwilioSmsChannel
/TwilioVoiceChannel
classes here as well.Thanks!!