-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PHP 8.1 #138
Comments
I understand 8.1 requires a breaking change, thus a 2.x release. Any idea when you plan to do this or what you want to accomplish before the next major release? |
So I wanted to get the Octane changes in (#83), as they are technically breaking but are unlikely to break most people's apps. So wanted to get them in the next major release rather than having to do yet another one for Octane. I've sorted that out today. I was thinking I'd hold off 2.0 until Laravel 9 came out as that is imminent. However, I'm starting to think that maybe I just do 2.0 now for Laravel 8 and if Laravel 9 introduces anything breaking I end up doing a 3.0 release just for that. I'm looking through Laravel JSON:API issues today and tomorrow, so will make a decision tomorrow about the 2.0 release. |
So an update on this now that I've spent a bit of time this Bank Holiday weekend looking at Laravel JSON:API issues. It turns out the main thing I need to sort out before tagging 2.0 for PHP 8.1 is that my use of internal interfaces (e.g. My plan is now to tag v2 as Laravel 8, PHP 7.4 -> PHP 8.1. Hopefully I'll get that tagged by the time Laravel 9 is released (Jan 25th apparently), so that I can then also tag v3. v3 will be Laravel 9, and will drop PHP 7.4 as Laravel are dropping that. Going forward, v1 will not be supported any more as the upgrade to v2 will be exceptionally simple. v2 and v3 will both be supported for bugfixes and minor (non-breaking) improvements/features. Any new breaking features will only go into v3. However it's worth noting that I'm not expecting any of those any time soon as I need to work through the backlog of issues that can be fixed in the currently supported releases before I move on to any features that will require breaking changes. |
For anyone wanting to use the dev version with PHP 8.1, set the composer require laravel-json-api/laravel:^2.0 --no-update
composer up laravel-json-api/* cloudcreativity/* |
According (this thread)[laravel-json-api/laravel#138], updating to version 2 is enough to support php 8 and above.
I see that 2.0 versions have quite stable code. Good job! ❤️ It's very difficult to update all the packages with their CI settings and |
I'm so close to just tagging
If you combine |
Just wanted to leave an update here that Laravel 9 release date got pushed from January 25th to February 8th -> laravel/docs@48aef38 |
Thanks for flagging that - anyone know why it has been pushed back?! Worth giving an update here. The untagged I am however really hesitant tagging So are people ok with me waiting until Feb 8th?! Or are people getting desperate for PHP 8.1 support on production?! |
I don't know anything else about that decision, that commit was the only reference to it that I could find. Speaking for myself, I'm fine with waiting for PHP 8.1 support until Laravel 9 is tagged. |
I've tagged Hoping to update the docs website tomorrow evening (UK time). |
Need to update the automated testing to check this package works with PHP 8.1, which is imminently about to be released.
There is definitely one breaking change required, see this issue:
laravel-json-api/eloquent#21
The text was updated successfully, but these errors were encountered: