-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize repository for use with Octane #83
Comments
And here's the missing piece that I thought was inevitable that they'd have to introduce... new container singletons that are flushed before handling a new HTTP request or queued job, via the |
I'd love to see octane support with this package. has there been any traction on this? |
No, haven't had time yet to do this as I've had very little Open Source time recently. If someone had time to help out, this issue might be good for PRs? The first step with this issue is to identify which singletons need to be modified to either |
I've made these changes, and they will be included in the 2.0 release. I believe they should work with Octane, but as I'm not using Octane it's a bit difficult to tell for sure. If anyone is using Octane and can give the 2.0 release a go when it's tagged, that'll be appreciated! |
I can test this out on 2.0 when tagged. Just @ me. |
@plunkettscott are you able to test out before I tag 2.0? You can install by setting your composer require laravel-json-api/laravel:^2.0 --no-update
composer up laravel-json-api/* |
Looks good. I haven't been able to inspect for memory leaks or anything yet, but if I notice them I'll report them. |
So that this package works with Laravel Octane, we need to replace any dependency injection of the container, HTTP request and config repository with lazy loading injections. As per these docs:
https://laravel.com/docs/8.x/octane#dependency-injection-and-octane
The text was updated successfully, but these errors were encountered: