Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: url with variable not work #12452

Merged
merged 2 commits into from
Jan 7, 2025
+6 −6
Merged

fix: url with variable not work #12452

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46c5bc8
fix url with variable not work
hjlarry Jan 7, 2025
bffd706
fix CI
hjlarry Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions api/core/workflow/nodes/http_request/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,6 @@ def __init__(
node_data.authorization.config.api_key
).text

# check if node_data.url is a valid URL
if not node_data.url:
raise InvalidURLError("url is required")
if not node_data.url.startswith(("http://", "https://")):
raise InvalidURLError("url should start with http:// or https://")

self.url: str = node_data.url
self.method = node_data.method
self.auth = node_data.authorization
Expand All @@ -99,6 +93,12 @@ def _initialize(self):
def _init_url(self):
self.url = self.variable_pool.convert_template(self.node_data.url).text

# check if url is a valid URL
if not self.url:
raise InvalidURLError("url is required")
if not self.url.startswith(("http://", "https://")):
raise InvalidURLError("url should start with http:// or https://")

def _init_params(self):
"""
Almost same as _init_headers(), difference:
Expand Down
Loading