Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: url with variable not work #12452

Merged
merged 2 commits into from
Jan 7, 2025
Merged

fix: url with variable not work #12452

merged 2 commits into from
Jan 7, 2025

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Jan 7, 2025

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

fix #12447

Screenshots

8f4729f4771f5eae8c38bbadaf464e6

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 7, 2025
@crazywoola crazywoola requested a review from laipz8200 January 7, 2025 13:43
Copy link
Contributor

@yihong0618 yihong0618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yihong0618
Copy link
Contributor

do we have other case, the first screen shot in the issue seems do not have variable

Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 7, 2025
@hjlarry
Copy link
Contributor Author

hjlarry commented Jan 7, 2025

do we have other case, the first screen shot in the issue seems do not have variable

It's easy to reproduce, make a code node's output a url, and a http node use the code node's output.
I only take a debug panel sceenshot.

@yihong0618
Copy link
Contributor

do we have other case, the first screen shot in the issue seems do not have variable

It's easy to reproduce, make a code node's output a url, and a http node use the code node's output. I only take a debug panel sceenshot.

cool very quick debugger!

@laipz8200 laipz8200 merged commit 67228c9 into langgenius:main Jan 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get node can't work: url should start with http:// or https://
3 participants