Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(community): Column VEC_VECTOR has the wrong length #6914

Merged
merged 2 commits into from
Oct 2, 2024
+4 −1
Merged

fix(community): Column VEC_VECTOR has the wrong length #6914

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d11ab59
Fix hanadb issue with default column length
prashantrakheja Oct 1, 2024
7e28048
Update comment
prashantrakheja Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion libs/langchain-community/src/vectorstores/hanavector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,11 @@ export class HanaDB extends VectorStore {
throw new Error(`Column ${columnName} has the wrong type: ${dataType}`);
}

// Length can either be -1 (QRC01+02-24) or 0 (QRC03-24 onwards)
// to indicate no length constraint being present.

// Check length, if parameter was provided
if (columnLength !== undefined && length !== columnLength) {
if (columnLength !== undefined && length !== columnLength && length > 0) {
throw new Error(`Column ${columnName} has the wrong length: ${length}`);
}
}
Expand Down
Loading