Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(community): Column VEC_VECTOR has the wrong length #6914

Merged
merged 2 commits into from
Oct 2, 2024
Merged

fix(community): Column VEC_VECTOR has the wrong length #6914

merged 2 commits into from
Oct 2, 2024

Conversation

prashantrakheja
Copy link
Contributor

  • Description: This PR fixes an issue with SAP HANA Cloud QRC03 version. In that version the number to indicate no length being set for a vector column changed from -1 to 0. The change in this PR support both behaviours (old/new).
  • Dependencies: No dependencies have been introduced.

The same issue has been fixed in the python library as well:
langchain-ai/langchain#23516

Fixes # (issue)
#6913

@prashantrakheja
Fix hanadb issue with default column length
d11ab59 
Signed-off-by: Prashant Rakheja <prashant.rakheja@sap.com>
@prashantrakheja
Update comment
7e28048 
Signed-off-by: Prashant Rakheja <prashant.rakheja@sap.com>
@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Oct 1, 2024 8:29am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Oct 1, 2024 8:29am

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. auto:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Oct 1, 2024
@prashantrakheja
Copy link
Contributor Author

cc @cinqisap @jacoblee93

@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 merged commit a7c46f5 into langchain-ai:main Oct 2, 2024
34 checks passed
@langchain-ai langchain-ai locked as spam and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prashantrakheja @jacoblee93