-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google-common[major]: Media manager #5835
Conversation
Testing
… a way that makes sense. Add option for fetch() that determines how to handle missing MediaBlobs.
… a way that makes sense. Add option for fetch() that determines how to handle missing MediaBlobs.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@@ -80,3 +81,49 @@ test("zodToGeminiParameters removes additional properties from arrays", () => { | |||
expect((arrayItemsSchema as any).additionalProperties).toBeUndefined(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey team, just wanted to flag that the new test suite "MediaBlob and BlobStore" includes a test case making an external HTTP request using the fetch
method. This change is flagged for review to ensure it aligns with our project's guidelines. Thanks!
@@ -0,0 +1,428 @@ | |||
import { v4 as uuidv4 } from "uuid"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey team, just wanted to flag that this PR introduces a new HTTP request using fetch
in the SimpleWebBlobStore
class. This comment is just to bring this change to your attention for review. Let me know if you have any questions or need further clarification.
Change default action if invalid blob. Add "ignore" action for invalid blobs.
Bug fix for BlobStore.store with how it handles the key
@afirstenberg is attempting to deploy a commit to the LangChain Team on Vercel. A member of the Team first needs to authorize it. |
WORK IN PROGRESS - FEEDBACK REQUESTED
There are still other tests and classes to implement, but this should give a first idea of where I see
MediaManager
as going.The goal is to provide infrastructure that supports the
fileData
part in the Gemini API.MediaManager
is platform (and LLM) neutral, but some of theBlobStore
implementations obviously aren't.MediaManager
- MediaMager will, itself, have no knowledge of the LLMsTODO:
BlobStore
for the AI Studio File API that backs the data somewhereOpen questions:
MediaBlob
serializableWill address #5075 #5076
cc: @jacoblee93 @bracesproul @eyurtsev