Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-common [Feature]: Support File API as media/metadata store #5075

Closed
1 task done
afirstenberg opened this issue Apr 11, 2024 · 1 comment
Closed
1 task done
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features

Comments

@afirstenberg
Copy link
Contributor

afirstenberg commented Apr 11, 2024

Privileged issue

  • I am a LangChain maintainer, or was asked directly by a LangChain maintainer to create an issue here.

Issue Content

Works on AI Studio only.

See https://ai.google.dev/api/rest/v1beta/files and https://ai.google.dev/api/rest/v1beta/media/upload
See https://github.com/google-gemini/cookbook/blob/main/quickstarts/Video.ipynb

See langchain-ai/langchain-google#147

This is an odd kind of store

  • You store the media file, and get back metadata including the URL.
  • Then you can use this URL for fileData messages to include the media.
  • It manages the file (it will delete it after 2 days).
  • There is no way to download the media, however, just the metadata.

I'd like to have this used in a couple of ways:

  • As a stand-alone component so devs can save the media and manage the URL themselves (initial priority)
  • As something used by the Chat module so if a file_url or media type is provided, it will save it to the File store and use the URL instead (future implementation)

What is the best interface to represent this with? In the past, @jacoblee93 has suggested subclassing BaseStore where the key is... a filename? And the value when set is just the file (in what form) and when retrieved is a Record<string,string>? I'm honestly not sure.

(I would also like a companion version, with the same interface, that words with Google Cloud Storage for use with Vertex. See #5076 )

@dosubot dosubot bot added the auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features label Apr 11, 2024
@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jul 11, 2024
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2024
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jul 18, 2024
@jacoblee93 jacoblee93 reopened this Jul 19, 2024
@afirstenberg
Copy link
Contributor Author

Being done as part of #5835

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Oct 18, 2024
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2024
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features
Projects
None yet
Development

No branches or pull requests

2 participants