Add num dimensions and metadata_mappings to ElasticsearchStore with testing #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssh-esh
changed the title
…and proper assertions
|
CI was passing but things are failing after my last commit (which was just a comment change). I am converting this to draft and deal with it tomorrow. I think it has to do with some tests still using FakeEmbeddings instead of our new ConsistentFakeEmbeddings which using determinstic hash based embeddings. It might be worth making a separate issue/PR to update all the FakeEmbeddings to use the new one and remove it entirely to avoid this random behaviour |
ssh-esh
changed the title
ezimuel
requested changes
Oct 3, 2025
| parameters, this test will fail and alert us to update AsyncElasticsearchStore. | ||
| """ | ||
| import inspect | ||
| from unittest.mock import AsyncMock, patch |
There was a problem hiding this comment.
The AsyncMock class is is already imported at the beginning of the file. Moreover, it's better to specify all the imports at the beginning of the file (see. PEP 8).
| async def test_parameter_forwarding_defaults(self) -> None: | ||
| """Test that default parameter values are properly forwarded to | ||
| AsyncEVectorStore.""" | ||
| from unittest.mock import AsyncMock, patch |
| ElasticsearchStore actually forwards. If EVectorStore adds new | ||
| parameters, this test will fail and alert us to update ElasticsearchStore. | ||
| """ | ||
| import inspect |
| def test_parameter_forwarding_defaults(self) -> None: | ||
| """Test that default parameter values are properly forwarded to | ||
| EVectorStore.""" | ||
| from unittest.mock import Mock, patch |
| hybrid_store.similarity_search_by_vector_with_relevance_scores([1, 2, 3]) | ||
|
|
||
| @pytest.mark.sync | ||
| def test_parameter_forwarding_to_evectorstore(self) -> None: |
There was a problem hiding this comment.
This is a very nice test! 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
Closes #69
Closes #76
Description
Adds num_dimensions and another missing param of metadata_mappings (the tests below I included caught this second missing param and i made issue above
metadata_mappingsis not supported inlangchain_elasticsearch.ElasticsearchStore#76 )Adds tests to detect missing params discrepancy between ElasticsearchStore and EVectorStore to catch these early in the future
Adds tests to make sure num_dimensions is working properly with integeration tests
Adds tests to check that metadata_mappings is working as expected with integeration tests