Fix wrong negation in Glob::glob()
introduced with 3.6.3
#46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #45.
Description
Currently, all CI actions all executed using Ubuntu (latest). In Glob.php there is a distinction of cases if the current distribution supports
GLOB_BRACE
or not. If it doessystemGlob()
is used, otherwisefallbackGlob()
is used.Now,
fallbackGlob()
just handlesGLOB_BRACE
and otherwise relies onsystemGlob()
. If there is an error like the one introduced in #43, then it can happen that such error is overlooked, because the underlying distribution (Ubuntu) supportsGLOB_BRACE
. Consequently, CI actions should not only be executed on Ubuntu, but also on a distribution not supportingGLOB_BRACE
, like Alpine linux.This PR adds a CI action running on Alpine Linux. PHPUnit on Alpine Linux brings 4 errors and 1 failure (see output):
The four errors about
iconv()
are because of a well-known issue withext-iconv
on Alpine Linux and not the fault of this package. I have added a check that skipsIconvTest
on Alpine Linux. See the following links for further information on this issue:The one failure is exactly the issue introduced in #43 with a wrong negation. That is fixed with the last commit of this PR.