Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #15 add test on glob and GLOB_BRACE flag #43

Merged

Conversation

garygitton
Copy link
Contributor

@garygitton garygitton commented Dec 15, 2021

Q A
Bugfix yes
QA yes

Description

Add test for issue #15

  • Add test on glob when GLOB_BRACE is not set
  • Improve an if condition with tests to improve readibilty

Fixes #15

@Ocramius Ocramius changed the base branch from 3.7.x to 3.6.x December 24, 2021 17:11
@Ocramius Ocramius added the Bug Something isn't working label Dec 24, 2021
@Ocramius Ocramius added this to the 3.6.3 milestone Dec 24, 2021
@Ocramius Ocramius self-assigned this Dec 24, 2021
Signed-off-by: Gary Gitton <gary.gitton@gmail.com>
@Ocramius Ocramius force-pushed the fix/bug-on-glob-evaluating-glob-brace branch from 93353e5 to df40f46 Compare December 24, 2021 17:19
@Ocramius Ocramius linked an issue Dec 24, 2021 that may be closed by this pull request
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and applied to 3.6.x (since it is a bugfix).

Thanks @garygitton!

@Ocramius Ocramius merged commit 6422838 into laminas:3.6.x Dec 24, 2021
driehle added a commit to driehle/laminas-stdlib that referenced this pull request Dec 29, 2021
Signed-off-by: Dennis Riehle <webmaster@riehle-web.com>
driehle added a commit to driehle/laminas-stdlib that referenced this pull request Dec 29, 2021
Signed-off-by: Dennis Riehle <webmaster@riehle-web.com>
driehle added a commit to driehle/laminas-stdlib that referenced this pull request Dec 29, 2021
Signed-off-by: Dennis Riehle <webmaster@riehle-web.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug on Glob evaluating GLOB_BRACE
2 participants