feat(hints): Implement NewHint#39 #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
requested review from
igaray,
Oppen,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
6 tasks
Oppen
approved these changes
Apr 21, 2023
Codecov Report
@@ Coverage Diff @@
## main #1037 +/- ##
=======================================
Coverage 98.07% 98.08%
=======================================
Files 84 84
Lines 33294 33345 +51
=======================================
+ Hits 32654 32705 +51
Misses 640 640
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
juanbono
approved these changes
Apr 23, 2023
pefontana
added
the
whitelisted-hint
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
omerfirmak
reviewed
Apr 25, 2023
| @@ -2,12 +2,27 @@ | |||
|
|
|||
| #### Upcoming Changes | |||
|
|
|||
| <<<<<<< HEAD | |||
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* Add test * Ignore builtin segments in get_memory_holes * Improve test * Add memory holes check for cairo_run_test tests * Fix broken condition * Make memory_holes check optional & customizable * Fix bounds * Add a test with deliberately created memory holes * Fix test value * Remove duplicated tests + add memory hole value to some tests * Add memory holes value + remove duplicated tests + fix typo * Fix test values * Add changelog entry * Link PR in Changelog * Mark breaking change in changelog * fmt * Fix test value * Fix codecov-patch diff * Add hint code * Add integration test * Add untracked file * Add changelog entry * Rename hint * Fix test * Fix test * Add hint code + hint impl + unit test * fmt * Add integration test * Add changelog entry * Implement hint + add tests * Add changelog entry * Remove indent from hint string * Add wasm import * Update CHANGELOG.md * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1036
TITLE
Description
Description of the pull request changes and motivation.
Checklist