Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hints): Implement NewHint#38 #1036

Merged
merged 43 commits into from
Apr 24, 2023
Merged

feat(hints): Implement NewHint#38 #1036

merged 43 commits into from
Apr 24, 2023

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Apr 21, 2023 •
edited
Loading

Depends on #1032

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

fmoletta and others added 30 commits April 20, 2023 12:57
@fmoletta
Add test
17716c4
@fmoletta
Ignore builtin segments in get_memory_holes
e867c2b
@fmoletta
Improve test
c560497
@fmoletta
Add memory holes check for cairo_run_test tests
ed5329f
@fmoletta
Fix broken condition
c15445b
@fmoletta
Make memory_holes check optional & customizable
f252960
@fmoletta
Fix bounds
063f9c4
@fmoletta
Add a test with deliberately created memory holes
6e3ed8b
@fmoletta
Fix test value
9fa2dc8
@fmoletta
Remove duplicated tests + add memory hole value to some tests
d36bf3f
@fmoletta
Add memory holes value + remove duplicated tests + fix typo
ece99eb
@fmoletta
Fix test values
1f867fb
@fmoletta
Add changelog entry
ac9c795
@fmoletta
Link PR in Changelog
356a187
@fmoletta
Merge branch 'main' of github.com:lambdaclass/cairo-rs into fix-get-m…
0f89514 
…emory-holes
@fmoletta
Mark breaking change in changelog
67e2622
@fmoletta
Merge branch 'main' of github.com:lambdaclass/cairo-rs into fix-get-m…
4a17d58 
…emory-holes
@fmoletta
fmt
e114745
@fmoletta
Fix test value
3ecf882
@fmoletta
Fix codecov-patch diff
342efdb
@fmoletta
Add hint code
67e3b70
@fmoletta
Add integration test
4779307
@fmoletta
Add untracked file
cbe3b5d
@fmoletta
Merge branch 'main' into div-mod-n-packed-hint
81a99e5
@fmoletta
Add changelog entry
a71552d
@fmoletta
Rename hint
75bb911
@fmoletta
Merge branch 'main' into div-mod-n-packed-hint
53ade42
@fmoletta
Fix test
23c7d8f
@fmoletta
Fix test
992c7fe
@fmoletta
Add hint code + hint impl + unit test
b434052
@github-actions
Copy link

github-actions bot commented Apr 21, 2023 •
edited
Loading

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 2.523 ± 0.049 2.478 2.612 1.02 ± 0.02
head blake2s_integration_benchmark 2.471 ± 0.036 2.444 2.562 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.076 ± 0.037 3.043 3.155 1.00 ± 0.01
head compare_arrays_200000 3.075 ± 0.017 3.053 3.100 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.417 ± 0.047 2.388 2.548 1.01 ± 0.02
head dict_integration_benchmark 2.400 ± 0.011 2.387 2.428 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 3.800 ± 0.024 3.774 3.857 1.02 ± 0.01
head factorial_multirun 3.738 ± 0.010 3.724 3.754 1.00
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 3.037 ± 0.016 3.021 3.071 1.01 ± 0.01
head fibonacci_1000_multirun 3.018 ± 0.036 2.971 3.098 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 128.9 ± 0.8 127.7 130.4 1.00
head field_arithmetic_get_square_benchmark 130.1 ± 2.9 128.1 138.3 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 2.997 ± 0.056 2.944 3.133 1.01 ± 0.02
head integration_builtins 2.980 ± 0.030 2.946 3.032 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 2.691 ± 0.014 2.663 2.711 1.00 ± 0.01
head keccak_integration_benchmark 2.679 ± 0.027 2.650 2.714 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.216 ± 0.025 3.190 3.269 1.00 ± 0.01
head linear_search 3.210 ± 0.026 3.182 3.254 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.730 ± 0.059 2.684 2.848 1.01 ± 0.02
head math_cmp_and_pow_integration_benchmark 2.708 ± 0.028 2.666 2.758 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.537 ± 0.039 2.493 2.641 1.01 ± 0.02
head math_integration_benchmark 2.507 ± 0.014 2.484 2.527 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.194 ± 0.026 2.158 2.254 1.01 ± 0.01
head memory_integration_benchmark 2.176 ± 0.008 2.166 2.190 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.254 ± 0.018 2.225 2.290 1.00
head operations_with_data_structures_benchmarks 2.309 ± 0.200 2.230 2.875 1.02 ± 0.09
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 786.7 ± 8.4 776.8 807.4 1.01 ± 0.01
head pedersen 781.0 ± 5.8 773.9 790.5 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.598 ± 0.231 1.497 2.252 1.04 ± 0.15
head poseidon_integration_benchmark 1.535 ± 0.011 1.519 1.551 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.402 ± 0.011 2.388 2.426 1.00 ± 0.01
head secp_integration_benchmark 2.397 ± 0.016 2.378 2.423 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.693 ± 0.004 1.688 1.701 1.00
head set_integration_benchmark 1.698 ± 0.027 1.682 1.773 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 3.936 ± 0.018 3.893 3.960 1.00
head uint256_integration_benchmark 3.968 ± 0.021 3.938 3.996 1.01 ± 0.01

@fmoletta fmoletta mentioned this pull request Apr 21, 2023
Merged
6 tasks
@fmoletta fmoletta changed the base branch from main to div-mod-n-packed-hint April 21, 2023 20:33
@fmoletta fmoletta marked this pull request as ready for review April 21, 2023 21:05
@codecov
Copy link

codecov bot commented Apr 21, 2023 •
edited
Loading

Codecov Report

Merging #1036 (44fd38e) into main (2eec112) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1036   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files          81       81           
  Lines       33083    33126   +43     
=======================================
+ Hits        32448    32491   +43     
  Misses        635      635
Impacted Files Coverage Δ
...int_processor/builtin_hint_processor_definition.rs 98.87% <100.00%> (+<0.01%) ⬆️
...int_processor/builtin_hint_processor/ec_recover.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pefontana pefontana added the whitelisted-hint Implementation of hint on whitelist directory label Apr 24, 2023
Base automatically changed from div-mod-n-packed-hint to main April 24, 2023 19:23
@fmoletta fmoletta enabled auto-merge April 24, 2023 19:33
@fmoletta fmoletta added this pull request to the merge queue Apr 24, 2023
Merged via the queue into main with commit fb73125 Apr 24, 2023
@fmoletta fmoletta deleted the new-hint-38 branch April 24, 2023 20:32
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
@fmoletta @kariy
feat(hints): Implement NewHint#38 (lambdaclass#1036)
f103bc4 
* Add test

* Ignore builtin segments in get_memory_holes

* Improve test

* Add memory holes check for cairo_run_test tests

* Fix broken condition

* Make memory_holes check optional & customizable

* Fix bounds

* Add a test with deliberately created memory holes

* Fix test value

* Remove duplicated tests + add memory hole value to some tests

* Add memory holes value + remove duplicated tests + fix typo

* Fix test values

* Add changelog entry

* Link PR in Changelog

* Mark breaking change in changelog

* fmt

* Fix test value

* Fix codecov-patch diff

* Add hint code

* Add integration test

* Add untracked file

* Add changelog entry

* Rename hint

* Fix test

* Fix test

* Add hint code + hint impl + unit test

* fmt

* Add integration test

* Add changelog entry

* Remove indent from hint string

* Add wasm import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanbono juanbono juanbono approved these changes

@Oppen Oppen Oppen approved these changes

@igaray igaray Awaiting requested review from igaray igaray is a code owner

@entropidelic entropidelic Awaiting requested review from entropidelic

@pefontana pefontana Awaiting requested review from pefontana pefontana is a code owner

@Juan-M-V Juan-M-V Awaiting requested review from Juan-M-V

Assignees
No one assigned
Labels
whitelisted-hint Implementation of hint on whitelist directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmoletta @Oppen @juanbono @pefontana