Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make email a required parameter #6

Merged
merged 2 commits into from
Jul 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ No modules.
|------|-------------|------|---------|:--------:|
| <a name="input_base_name"></a> [base\_name](#input\_base\_name) | Names for the created resources will be ${base\_name}\_{user,group} | `string` | `"lacework_security_integration"` | no |
| <a name="input_create"></a> [create](#input\_create) | Set to false to prevent module from creating any resources | `bool` | `true` | no |
| <a name="input_email"></a> [email](#input\_email) | Optional email associated with the created user | `string` | `"lacework@lacework.net"` | no |
| <a name="input_email"></a> [email](#input\_email) | Email associated with the created user | `string` | n/a | yes |
| <a name="input_freeform_tags"></a> [freeform\_tags](#input\_freeform\_tags) | freeform tags for the resources created for Lacework integration | `map(any)` | `{}` | no |
| <a name="input_group_name"></a> [group\_name](#input\_group\_name) | Name of the identity group for the Lacework user (overrides base\_name) | `string` | `""` | no |
| <a name="input_tenancy_id"></a> [tenancy\_id](#input\_tenancy\_id) | OCID of the OCI tenancy to be integrated with Lacework | `string` | n/a | yes |
Expand Down
1 change: 1 addition & 0 deletions examples/custom-iam-user/main.tf
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
module "lacework_iam_user" {
source = "../.."
tenancy_id = var.tenancy_ocid
email = "example@example.com"
base_name = "lacework_test"
}

Expand Down
1 change: 1 addition & 0 deletions examples/default-iam-user/main.tf
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
module "lacework_iam_user" {
source = "../.."
tenancy_id = var.tenancy_ocid
email = "example@example.com"
}

variable "tenancy_ocid" {
Expand Down
1 change: 1 addition & 0 deletions examples/skip-creation-iam-user/main.tf
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
module "lacework_iam_user" {
source = "../.."
tenancy_id = var.tenancy_ocid
email = "example@example.com"
create = false
}

Expand Down
11 changes: 5 additions & 6 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ variable "tenancy_id" {
description = "OCID of the OCI tenancy to be integrated with Lacework"
}

variable "email" {
type = string
description = "Email associated with the created user"
}

# Optional

variable "create" {
Expand All @@ -19,12 +24,6 @@ variable "freeform_tags" {
description = "freeform tags for the resources created for Lacework integration"
}

variable "email" {
type = string
default = "lacework@lacework.net"
description = "Optional email associated with the created user"
}

variable "base_name" {
type = string
default = "lacework_security_integration"
Expand Down