Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make email a required parameter #6

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Conversation

kolbeinn
Copy link
Contributor

Summary

This module creates an OCI user for the Lacework integration. OCI users need have an email. This PR makes the user email a required parameter instead of defaulting to 'lacework@lacework.net', which users do not have access to.

How did you test this change?

Run the default example and make sure nothing broke:

cd examples/default-iam-user
tf init
TF_VAR_tenancy_ocid=<tenancy_ocid> tf plan
TF_VAR_tenancy_ocid=<tenancy_ocid> tf validate

Issue

N/A

Signed-off-by: Kolbeinn Karlsson <kolbeinn.karlsson@lacework.net>
Signed-off-by: Kolbeinn Karlsson <kolbeinn.karlsson@lacework.net>
@dmurray-lacework
Copy link
Contributor

When email is not supplied what is the error outputted by Terraform?

If the current error is not helpful perhaps adding validation to the var could allow a better output.

https://developer.hashicorp.com/terraform/language/values/variables#custom-validation-rules

@kolbeinn
Copy link
Contributor Author

When email is not supplied what is the error outputted by Terraform?

If the current error is not helpful perhaps adding validation to the var could allow a better output.

https://developer.hashicorp.com/terraform/language/values/variables#custom-validation-rules

Good question. Let me check and add custom validation as needed.

@kolbeinn
Copy link
Contributor Author

@dmurray-lacework The error message seems fine to me. Happy to add a custom one if anybody has a better one, though.

Screenshot 2023-07-13 at 1 17 30 PM

@kolbeinn kolbeinn merged commit 13c557d into main Jul 13, 2023
@kolbeinn kolbeinn deleted the make-email-required branch July 13, 2023 13:25
@lacework-releng lacework-releng mentioned this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants