Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Deprecate single sign-on-like auth token for the pipeline service #1730

Closed
wants to merge 10 commits into from
Closed

feat: Deprecate single sign-on-like auth token for the pipeline service #1730

wants to merge 10 commits into from

Conversation

rapsealk
Copy link
Member

@rapsealk rapsealk commented Nov 22, 2023 •
edited
Loading

This PR reverts #1350

It has been observed that forcing users to log in to WebUI and then to the pipeline service makes user experience bad.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Documentation
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to demonstrate the difference of before/after

@rapsealk rapsealk added this to the 23.09 milestone Nov 22, 2023
@rapsealk rapsealk self-assigned this Nov 22, 2023
@github-actions github-actions bot added comp:webserver Related to Web Server component size:M 30~100 LoC labels Nov 22, 2023
@rapsealk rapsealk added area:security Security issue. platform:enterprise Backend.AI Enterprise support. labels Nov 22, 2023
@rapsealk rapsealk modified the milestones: 23.09, 24.03 Mar 28, 2024
@github-actions github-actions bot added size:S 10~30 LoC and removed size:M 30~100 LoC labels Apr 4, 2024
@github-actions github-actions bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels Apr 4, 2024
@rapsealk rapsealk changed the title feature: Deprecate pipeline auth token and use anonymous session feat: Deprecate single sign-on-like auth token for the pipeline service Apr 4, 2024
achimnol
achimnol approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a simple code removal, I don't have specific code-level reviews. Please ensure that the fieldops team to know any necessary configuration changes in the FastTrack side.

@achimnol Graphite App
Copy link
Member

achimnol commented May 3, 2024

And also update the PR to resolve conflicts with the latest main branch.

@rapsealk
Copy link
Member Author

This pull request will be superseded by a further work: WebUI redirection.

@rapsealk rapsealk closed this May 13, 2024
@rapsealk rapsealk deleted the feature/sunset-pipeline-jwt branch May 13, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimnol achimnol achimnol approved these changes

@kyujin-cho kyujin-cho Awaiting requested review from kyujin-cho

Assignees

@rapsealk rapsealk

Labels
area:security Security issue. comp:webserver Related to Web Server component platform:enterprise Backend.AI Enterprise support. size:M 30~100 LoC
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.
2 participants
@rapsealk @achimnol