Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Issue a signed token for authorizing the pipeline service #1350

Merged
merged 8 commits into from
Jul 24, 2023

Conversation

rapsealk
Copy link
Member

@rapsealk rapsealk commented Jun 27, 2023

This PR updates the proxy handler for the pipeline service.

To use a Backend.AI Webserver session as a single-sourced value for authorizing other services, such as the pipeline service, the Webserver issues a token that is signed with a shared key.

A token contains aiohttp_session to avoid the case when having a session and a token for different users each.

@rapsealk rapsealk added type:feature Add new features area:security Security issue. platform:enterprise Backend.AI Enterprise support. comp:webserver Related to Web Server component effort:normal Need to understand a few modules / some extent of contextual or historical information. impact:invisible This change is invisible to users (internal changes). size:S 10~30 LoC status:open Waiting for volunteer / assignnee. urgency:4 As soon as feasible, implementation is essential. labels Jun 27, 2023
@rapsealk rapsealk added this to the 23.03 milestone Jun 27, 2023
@rapsealk rapsealk self-assigned this Jun 27, 2023
@rapsealk rapsealk marked this pull request as ready for review June 28, 2023 00:45
@rapsealk rapsealk requested a review from achimnol June 28, 2023 00:45
@rapsealk rapsealk marked this pull request as draft June 28, 2023 02:57
@rapsealk rapsealk marked this pull request as ready for review June 28, 2023 03:36
@rapsealk rapsealk marked this pull request as draft June 28, 2023 06:49
@rapsealk rapsealk marked this pull request as ready for review July 17, 2023 02:06
@achimnol achimnol added this pull request to the merge queue Jul 24, 2023
Merged via the queue into main with commit 8cc7a68 Jul 24, 2023
@achimnol achimnol deleted the feature/pipeline-auth-token branch July 24, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:security Security issue. comp:webserver Related to Web Server component effort:normal Need to understand a few modules / some extent of contextual or historical information. impact:invisible This change is invisible to users (internal changes). platform:enterprise Backend.AI Enterprise support. size:S 10~30 LoC status:open Waiting for volunteer / assignnee. type:feature Add new features urgency:4 As soon as feasible, implementation is essential.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants