-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Issue a signed token for authorizing the pipeline service #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapsealk
added
type:feature
Add new features
area:security
Security issue.
platform:enterprise
Backend.AI Enterprise support.
comp:webserver
Related to Web Server component
effort:normal
Need to understand a few modules / some extent of contextual or historical information.
impact:invisible
This change is invisible to users (internal changes).
size:S
10~30 LoC
status:open
Waiting for volunteer / assignnee.
urgency:4
As soon as feasible, implementation is essential.
labels
Jun 27, 2023
achimnol
approved these changes
Jul 24, 2023
achimnol
pushed a commit
that referenced
this pull request
Jul 24, 2023
Backported-from: main Backported-to: 23.03
5 tasks
5 tasks
5 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:security
Security issue.
comp:webserver
Related to Web Server component
effort:normal
Need to understand a few modules / some extent of contextual or historical information.
impact:invisible
This change is invisible to users (internal changes).
platform:enterprise
Backend.AI Enterprise support.
size:S
10~30 LoC
status:open
Waiting for volunteer / assignnee.
type:feature
Add new features
urgency:4
As soon as feasible, implementation is essential.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the proxy handler for the pipeline service.
To use a Backend.AI Webserver session as a single-sourced value for authorizing other services, such as the pipeline service, the Webserver issues a token that is signed with a shared key.
A token contains
aiohttp_session
to avoid the case when having a session and a token for different users each.