Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding API Gateway job provisioning Gardener cluster #6783

Merged

Conversation

videlov
Copy link
Contributor

@videlov videlov commented Jan 24, 2023

Description

Changes proposed in this pull request:

  • Adding API Gateway validation integration tests job

Related issue(s)

kyma-project/api-gateway#149

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2023
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 24, 2023
@videlov videlov requested a review from kasiakepka January 24, 2023 14:25
kasiakepka
kasiakepka previously approved these changes Jan 25, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 25, 2023
@videlov videlov removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 25, 2023
@videlov videlov marked this pull request as ready for review January 25, 2023 11:27
@videlov videlov requested a review from a team as a code owner January 25, 2023 11:27
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 25, 2023
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 25, 2023
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 25, 2023
vpath/pjtester.yaml Outdated Show resolved Hide resolved
@dekiel
Copy link
Contributor

dekiel commented Jan 31, 2023

/test pull-test-infra-pjtester

@kasiakepka kasiakepka added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2023
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Feb 8, 2023

❌ Plan Failed

It failed to parse the result.

Details (Click me)
╷
│ Error: No configuration files
│ 
│ Plan requires configuration to be present. Planning without a configuration
│ would mark everything for destruction, which is normally not what is
│ desired. If you would like to destroy everything, run plan with the
│ -destroy option. Otherwise, create a Terraform configuration file (.tf
│ file) and try again.

@videlov videlov requested a review from kasiakepka February 8, 2023 11:36
cnvergence
cnvergence previously approved these changes Feb 9, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 9, 2023
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Feb 9, 2023
@videlov videlov requested a review from cnvergence February 9, 2023 10:28
@kyma-bot
Copy link
Contributor

kyma-bot commented Feb 9, 2023

@videlov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-secret-leaks-log-scanner-tf-plan 05a595e link true /test pull-secret-leaks-log-scanner-tf-plan
pull-hide-tf-github-comments 05a595e link true /test pull-hide-tf-github-comments

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@cnvergence cnvergence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 9, 2023
@videlov videlov removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2023
@kyma-bot kyma-bot merged commit e892865 into kyma-project:main Feb 10, 2023
@kyma-bot
Copy link
Contributor

@videlov: Updated the following 2 configmaps:

  • job-config configmap in namespace default at cluster default using the following files:
    • key api-gateway-validation.yaml using file prow/jobs/api-gateway/api-gateway-validation.yaml
  • config configmap in namespace default at cluster default using the following files:
    • key config.yaml using file prow/config.yaml

In response to this:

Description

Changes proposed in this pull request:

  • Adding API Gateway validation integration tests job

Related issue(s)

kyma-project/api-gateway#149

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kasiakepka pushed a commit to kasiakepka/test-infra that referenced this pull request May 4, 2023
* Adding API Gateway validation integration tests job

* Newline

* Change key name for the secrets

* Revert manual changes

* make jobs-definitions

* Test run it

* Hmm

* Fix pjtester project ref

* Provision gardener job

* Changes

* Fix wrong conflict resolve

* Move linting & testing to global sets

* Fixes

* Simplify

* Fixing new job inherited configs

* Change clone repo dir

* Extra refs

* Do not run kyma component tests

* Render templates

* Skip tests

* Remove job tester

* Extend for API-Gateway integration tests

* pjtester

* remove pjtester

* Render template
muralov pushed a commit to muralov/test-infra that referenced this pull request Jun 1, 2023
* Adding API Gateway validation integration tests job

* Newline

* Change key name for the secrets

* Revert manual changes

* make jobs-definitions

* Test run it

* Hmm

* Fix pjtester project ref

* Provision gardener job

* Changes

* Fix wrong conflict resolve

* Move linting & testing to global sets

* Fixes

* Simplify

* Fixing new job inherited configs

* Change clone repo dir

* Extra refs

* Do not run kyma component tests

* Render templates

* Skip tests

* Remove job tester

* Extend for API-Gateway integration tests

* pjtester

* remove pjtester

* Render template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants