-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use script to generate local module template with release meta #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Nov 22, 2024
kyma-bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Nov 25, 2024
ruanxin
force-pushed
the
update-moduetemplate
branch
from
November 25, 2024 12:56
8f68fce
to
61efe44
Compare
# Conflicts: # .github/actions/deploy-template-operator-with-modulereleasemeta/action.yml
kyma-bot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Nov 25, 2024
ruanxin
force-pushed
the
update-moduetemplate
branch
from
November 25, 2024 19:21
fc82f97
to
e834835
Compare
ruanxin
force-pushed
the
update-moduetemplate
branch
from
November 26, 2024 16:14
c48753c
to
303492e
Compare
ruanxin
force-pushed
the
update-moduetemplate
branch
from
November 26, 2024 17:55
9daa6f8
to
cabfe6f
Compare
ruanxin
force-pushed
the
update-moduetemplate
branch
from
November 26, 2024 20:06
e7718e0
to
05618b9
Compare
c-pius
reviewed
Nov 27, 2024
.github/actions/deploy-template-operator-with-modulereleasemeta/action.yml
Outdated
Show resolved
Hide resolved
.github/actions/deploy-template-operator-with-modulereleasemeta/action.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Christoph Schwägerl <acc.pius@mailbox.org>
…a/action.yml Co-authored-by: Christoph Schwägerl <acc.pius@mailbox.org>
Co-authored-by: Christoph Schwägerl <acc.pius@mailbox.org>
c-pius
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update E2E with ModuleReleaseMeta
module-upgrade-new-version
tomodulereleasemeta-module-upgrade-new-version
with new testing code.upgrade-under-deletion
tomodulereleasemeta-upgrade-under-deletion
with new testing code.ocm-compatible-module-template
since modulectl generates with new ocm format.fix a potential bug that not update Manifest CR state when managerState is in StateError https://github.com/kyma-project/lifecycle-manager/pull/2054/files#diff-45632cfa5b5d235890e597e29448382f7c61fc85a55d1629de012328056e69a2R388-R390
enhance the debugging of the e2e test to print kyma and manifest each 30s with goroutine https://github.com/kyma-project/lifecycle-manager/pull/2054/files#diff-265d9afff5b7148558247b1c711ccd6cdda5ab32fe4e14ca2c5f7013f895333cR103-R104
Related issue(s)
#1956
TODO:
SetManifestState
into more readableRequireManifestStateUpdateAfterSyncResource
, to align the purpose that only update state if it's different from old state. https://github.com/kyma-project/lifecycle-manager/pull/2054/files#diff-4c84564e62c77448636a921b57a22d22f133d80bec8ae89e9cd6ee4c195f132eL17