Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Module Catalog] Remove the ModuleTemplate name overwrite in E2E tests for ModuleReleaseMeta #1956

Closed
2 tasks done
nesmabadr opened this issue Oct 14, 2024 · 2 comments · Fixed by #2054
Closed
2 tasks done

[Module Catalog] Remove the ModuleTemplate name overwrite in E2E tests for ModuleReleaseMeta #1956

nesmabadr opened this issue Oct 14, 2024 · 2 comments · Fixed by #2054
Assignees
@ruanxin
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@nesmabadr
Copy link
Contributor

nesmabadr commented Oct 14, 2024 •
edited by lindnerby
Loading

Description

Right now in the E2E tests which are run with ModuleReleaseMeta, we have a step to overwrite the name of the ModuleTemplate to be moduleName-version. We need to remove this overwrite after the modulectl allows the creation of ModuleTemplate with the new name format and the E2E tests workflows are actually using the modulectl not the Kyma CLI.

Reasons

No response

Acceptance Criteria

Feature Testing

No response

Testing approach

No response

Attachments

No response
@nesmabadr nesmabadr added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 14, 2024
@nesmabadr
Copy link
Contributor Author

Blocked by kyma-project/modulectl#62

@ruanxin ruanxin self-assigned this Nov 13, 2024
@ruanxin
Copy link
Contributor

ruanxin commented Nov 19, 2024

blocked by kyma-project/modulectl#98

@ruanxin ruanxin mentioned this issue Nov 22, 2024
Merged
@lindnerby lindnerby linked a pull request Nov 26, 2024 that will close this issue
chore: Use script to generate local module template with release meta #2054
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruanxin ruanxin

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Use script to generate local module template with release meta ruanxin/kyma-operator
2 participants
@ruanxin @nesmabadr