Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reconciler dependency #802

Merged
merged 6 commits into from
Jun 7, 2024
Merged

Remove reconciler dependency #802

merged 6 commits into from
Jun 7, 2024

Conversation

KsaweryZietara
Copy link
Contributor

@KsaweryZietara KsaweryZietara commented Jun 5, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • remove ClusterSetup from RuntimeState,
  • remove reconcilerApi from tests,
  • remove reconciler feature flag,
  • remove unused reconciler fields from operation.

Related issue(s)
See #536, kyma-project/control-plane#2498 (comment)

@KsaweryZietara KsaweryZietara added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Jun 5, 2024
@KsaweryZietara KsaweryZietara self-assigned this Jun 5, 2024
@KsaweryZietara KsaweryZietara requested a review from a team as a code owner June 5, 2024 06:40
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Jun 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 5, 2024
@KsaweryZietara KsaweryZietara mentioned this pull request Jun 5, 2024
Closed
21 tasks
@KsaweryZietara KsaweryZietara added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2024
@KsaweryZietara KsaweryZietara force-pushed the cleanup-reconciler-dependency branch from 2c089d6 to 98bc809 Compare June 6, 2024 12:18
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 6, 2024
@KsaweryZietara KsaweryZietara force-pushed the cleanup-reconciler-dependency branch from d212744 to e5db49d Compare June 7, 2024 06:52
@KsaweryZietara KsaweryZietara removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 7, 2024
@kyma-bot kyma-bot merged commit 1ce5e90 into kyma-project:main Jun 7, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrmiskiewicz piotrmiskiewicz piotrmiskiewicz approved these changes

Assignees

@piotrmiskiewicz piotrmiskiewicz

@KsaweryZietara KsaweryZietara

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KsaweryZietara @piotrmiskiewicz @kyma-bot