List all cleanup changes we need to apply to KEB when we will work with Lifecycle Manager only

[PK85]

Description

Soon or later all modules will be supported only via Lifecycle Manager. This ticket is about preparing a list of tasks that we need to remove from KEB code, e.g. overrides, kyma version etc

AC

• 1) Find all features in the KEB that will be abandoned when we will use Lifecycle Manager only
• 2) Prepare tasks ready to be taken in the next sprints.

Timeboxed to Size/S.

[kyma-bot]

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

• After 60d of inactivity, lifecycle/stale is applied
• After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

[kyma-bot]

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

• After 60d of inactivity, lifecycle/stale is applied
• After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

[kyma-bot]

@kyma-bot: Closing this issue.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

• After 60d of inactivity, lifecycle/stale is applied
• After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kyma-bot]

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

• After 60d of inactivity, lifecycle/stale is applied
• After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

[kyma-bot]

@kyma-bot: Closing this issue.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

• After 60d of inactivity, lifecycle/stale is applied
• After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[piotrmiskiewicz]

LM manager does not get any overrides, additional components and Kyma Version.

Functionality, which could be removed

Steps to remove (overrides and Reconciler):

1. Provisioning:

• OverridesFromSecretsAndConfigStep (overrides)
• BTPOperatorOverridesStep (overrides), note: check if cluster ID is needed
• CreateClusterConfiguration (reconciler)
• CheckClusterConfigurationStep (reconciler)

2. Update:

• BTPOperatorOverridesStep
• ApplyReconcilerConfigurationStep
• CheckReconcilerState

3. Deprovision

• DeregisterClusterStep
• CheckClusterDeregistration

4. Upgrade Kyma

• BTPOperatorOverridesStep
• OverridesFromSecretsAndConfigStep
• ApplyClusterConfigurationStep
• CheckClusterConfigurationStep

Steps to modify:

provisioning/initialisation.go - remove disabling BTP component code

Packages to remove

internal/runtimeoverrides
internal/version
internal/reconciler

Remove reconciler deps

Remove any dependency to github.com/kyma-incubator/reconciler/pkg/keb

RuntimeInput cleanup

1. Remove the following methods:

• EnableOptionalComponent
• DisableOptionalComponent
• SetOverrides, AppendOverrides
• AppendGlobalOverrides
• CreateClusterConfiguration

2. Remove the following fields: overrides, globalOverrides, componentsDisabler, enabledOptionalComponents

InputBuilderFactory cleanup

Remove the following fields (and corresponding methods): optComponentsSvc, componentsProvider, disabledComponentsProvider

[piotrmiskiewicz]

Tasks:

• Remove (or modify) unnecessary steps (listerd in the previous comment)
• Cleanup RuntimeInput, InputBuilderFactory
• Remove unused packages, make sure reconciler dependency is not used

[piotrmiskiewicz]

Question about Kyma Version:
After the LM integration we do not need this, but we can use it for testing some new features (like preview plan)
Question: what about setting version per subaccount/globalaccount ?

[ralikio]

We are removing Kyma version completely.

[szwedm]

@piotrmiskiewicz nice summary, I went through the code and spotted pretty much the same places for changes/cleanup. If we drop Kyma versions then we can still prepare configurations per plan.