Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kim with OIDC #1019

Merged
merged 8 commits into from
Aug 9, 2024
Merged

Kim with OIDC #1019

merged 8 commits into from
Aug 9, 2024

Conversation

piotrmiskiewicz
Copy link
Member

@piotrmiskiewicz piotrmiskiewicz commented Aug 8, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • fill all runtime.spec.kubernetes necessary fields
  • a fallback in the deprovisioning for a case, when the name of runtime resource was not stored in the DB (created by migration process)

Related issue(s)

#905
#791

@kyma-bot
Copy link
Contributor

kyma-bot commented Aug 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2024
@piotrmiskiewicz
Copy link
Member Author

/test all

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 8, 2024
@kyma-bot
Copy link
Contributor

kyma-bot commented Aug 8, 2024

@piotrmiskiewicz: No jobs can be run with /test all.
The following commands are available to trigger required jobs:

  • /test pull-kyma-environment-broker-pjconfigtest
  • /test pull-kyma-environment-broker-pjtester
  • /test pull-kyma-environment-broker-vpathguard

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 8, 2024
@piotrmiskiewicz piotrmiskiewicz marked this pull request as ready for review August 8, 2024 15:56
@piotrmiskiewicz piotrmiskiewicz requested a review from a team as a code owner August 8, 2024 15:56
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2024
@piotrmiskiewicz piotrmiskiewicz added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Aug 8, 2024
jaroslaw-pieszka
jaroslaw-pieszka reviewed Aug 9, 2024
View reviewed changes
internal/process/provisioning/create_runtime_resource_step.go
UsernamePrefix: &s.oidcDefaultValues.UsernamePrefix,
}
if operation.ProvisioningParameters.Parameters.OIDC != nil {
if operation.ProvisioningParameters.Parameters.OIDC.ClientID != "" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use DefaultIfParamNotSet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately no, it expects param as a pointer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 9, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Aug 9, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 9, 2024
@kyma-bot kyma-bot merged commit e1039a6 into kyma-project:main Aug 9, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@piotrmiskiewicz @kyma-bot @jaroslaw-pieszka @KsaweryZietara