Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Runtime Reconciler with a state machine #247

Merged
merged 77 commits into from
Jun 27, 2024

Conversation

koala7659
Copy link
Contributor

@koala7659 koala7659 commented May 31, 2024

  • State machine for Runtime controller based on existing implementation in application-connector-manager project
  • Implementation of full Provisioning flow with state machine
  • General refactor of the controller part (path internal/controller ) to put 2 controllers into separate packages
  • New interface to Gardener Shoot Provider
  • Integration tests with testing suite based on testenv framework
  • Unit tests of state machine
  • Correct Runtime states and conditions (see Valid CRs statuses should be set when KIM's operations succeed or fail #193)

Flow chart:

stateDiagram-v2
    [*] --> sFnTakeSnapshot
     sFnTakeSnapshot --> sFnInitialize 
     sFnInitialize --> sFnCreateShoot
     sFnCreateShoot --> sFnPersistShoot
     sFnPersistShoot --> [*]
     sFnInitialize --> sFnPrepareCluster
     sFnPrepareCluster --> ProcessShoot
     ProcessShoot --> [*]
     sFnInitialize --> sFnDeleteShoot 
     sFnDeleteShoot --> [*]
Loading

@koala7659 koala7659 requested a review from a team as a code owner May 31, 2024 13:22
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 31, 2024
@tobiscr tobiscr mentioned this pull request Jun 4, 2024
2 tasks
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 10, 2024
@koala7659 koala7659 changed the title WIP Adding empty state machine to Runtime Reconciler for future implementation WIP Implementing Runtime Reconciler with a help of state machine Jun 10, 2024
@koala7659 koala7659 changed the title WIP Implementing Runtime Reconciler with a help of state machine WIP Implementing Runtime Reconciler with a state machine Jun 10, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 10, 2024
akgalwas
akgalwas previously approved these changes Jun 25, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 25, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jun 25, 2024
@kyma-bot kyma-bot added the area/ci Issues or PRs related to CI related topics label Jun 26, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 27, 2024
@kyma-bot kyma-bot merged commit f7b3710 into kyma-project:main Jun 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants