fix linter errors 6

internal/controller/runtime/fsm/runtime_fsm.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"reflect"
 	"runtime"
+	"time"
 
 	"github.com/go-logr/logr"
 	imv1 "github.com/kyma-project/infrastructure-manager/api/v1"
@@ -17,6 +18,10 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/source"
 )
 
+const (
+	gardenerRequeueDuration = 15 * time.Second
+)
+
 type stateFn func(context.Context, *fsm, *systemState) (stateFn, *ctrl.Result, error)
 
 // runtime reconciler specific configuration

internal/controller/runtime/fsm/runtime_fsm_create_shoot.go

@@ -42,7 +42,7 @@ func sFnCreateShoot(ctx context.Context, m *fsm, s *systemState) (stateFn, *ctrl
 			"Gardener API create error",
 		)
 
-		return stopWithRequeueAfter(15 * time.Second)
+		return stopWithRequeueAfter(gardenerRequeueDuration)
 	}
 
 	m.log.Info("Gardener shoot for runtime initialised successfully", "Name", s.shoot.Name, "Namespace", s.shoot.Namespace)

internal/controller/runtime/fsm/runtime_fsm_initialise_test.go

@@ -2,22 +2,18 @@ package fsm
 
 import (
 	"context"
-
-	"k8s.io/apimachinery/pkg/api/meta"
-
-	"sigs.k8s.io/controller-runtime/pkg/client"
-
 	"time"
 
 	gardener "github.com/gardener/gardener/pkg/apis/core/v1beta1"
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/apimachinery/pkg/runtime"
-	util "k8s.io/apimachinery/pkg/util/runtime"
-
 	imv1 "github.com/kyma-project/infrastructure-manager/api/v1"
 	. "github.com/onsi/ginkgo/v2" //nolint:revive
 	. "github.com/onsi/gomega"    //nolint:revive
 	"github.com/onsi/gomega/types"
+	"k8s.io/apimachinery/pkg/api/meta"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/runtime"
+	util "k8s.io/apimachinery/pkg/util/runtime"
+	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
 var withTestFinalizer = withFinalizer("test-me-plz")

internal/controller/runtime/fsm/runtime_fsm_prepare_cluster.go

@@ -4,33 +4,32 @@ import (
 	"context"
 	"fmt"
 	"strings"
-	"time"
+
+	imv1 "github.com/kyma-project/infrastructure-manager/api/v1"
 
 	gardener "github.com/gardener/gardener/pkg/apis/core/v1beta1"
 	gardenerhelper "github.com/gardener/gardener/pkg/apis/core/v1beta1/helper"
-	imv1 "github.com/kyma-project/infrastructure-manager/api/v1"
 	ctrl "sigs.k8s.io/controller-runtime"
 )
 
 type ErrReason string
 
 func sFnPrepareCluster(_ context.Context, m *fsm, s *systemState) (stateFn, *ctrl.Result, error) {
-
 	if s.shoot == nil {
 		return stopWithErrorAndNoRequeue(fmt.Errorf("fatal state machine logic problem: Shoot can never be nil in PrepareCluster state"))
 	}
 
 	if s.shoot.Spec.DNS == nil || s.shoot.Spec.DNS.Domain == nil {
 		msg := fmt.Sprintf("DNS Domain is not set yet for shoot: %s, scheduling for retry", s.shoot.Name)
 		m.log.Info(msg)
-		return stopWithRequeueAfter(time.Second * 15)
+		return stopWithRequeueAfter(gardenerRequeueDuration)
 	}
 
 	lastOperation := s.shoot.Status.LastOperation
 	if lastOperation == nil {
 		msg := fmt.Sprintf("Last operation is nil for shoot: %s, scheduling for retry", s.shoot.Name)
 		m.log.Info(msg)
-		return stopWithRequeueAfter(time.Second * 15)
+		return stopWithRequeueAfter(gardenerRequeueDuration)
 	}
 
 	if lastOperation.Type == gardener.LastOperationTypeCreate {
@@ -46,7 +45,7 @@ func sFnPrepareCluster(_ context.Context, m *fsm, s *systemState) (stateFn, *ctr
 				"Unknown",
 				"Shoot creation in progress")
 
-			return stopWithRequeueAfter(time.Second * 15)
+			return stopWithRequeueAfter(gardenerRequeueDuration)
 		}
 
 		if lastOperation.State == gardener.LastOperationStateSucceeded {
@@ -70,7 +69,7 @@ func sFnPrepareCluster(_ context.Context, m *fsm, s *systemState) (stateFn, *ctr
 			if gardenerhelper.HasErrorCode(s.shoot.Status.LastErrors, gardener.ErrorInfraRateLimitsExceeded) {
 				msg := fmt.Sprintf("Error during cluster provisioning: Rate limits exceeded for Shoot %s, scheduling for retry", s.shoot.Name)
 				m.log.Info(msg)
-				return stopWithRequeueAfter(time.Second * 15)
+				return stopWithRequeueAfter(gardenerRequeueDuration)
 			}
 
 			msg := fmt.Sprintf("Provisioning failed for shoot: %s ! Last state: %s, Description: %s", s.shoot.Name, lastOperation.State, lastOperation.Description)

internal/controller/runtime/fsm/state_fn_instance_status_matcher_test.go

@@ -32,10 +32,10 @@ func (m *instanceConditionMatcher) Match(actual any) (success bool, err error) {
 	return Equal(m.expected).Match(m.actual)
 }
 
-func (m *instanceConditionMatcher) FailureMessage(actual interface{}) (message string) {
+func (m *instanceConditionMatcher) FailureMessage(_ interface{}) (message string) {
 	return fmt.Sprintf("Expected\n\t%v\nto contain\n\t%s", m.actual, m.expected)
 }
 
-func (m *instanceConditionMatcher) NegatedFailureMessage(actual interface{}) (message string) {
+func (m *instanceConditionMatcher) NegatedFailureMessage(_ interface{}) (message string) {
 	return fmt.Sprintf("Expected\n\t%v\nnot to contain\n\t%s", m.actual, m.expected)
 }

internal/controller/runtime/fsm/utilz_for_test.go

@@ -4,7 +4,7 @@ import (
 	"fmt"
 
 	gardener_mocks "github.com/kyma-project/infrastructure-manager/internal/gardener/mocks"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/gomega" //nolint:revive
 	"k8s.io/apimachinery/pkg/runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/client/fake"