fix(kuma-cp) remove insight update rate limit burst (backport #2825) #2835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
The token burst that is configured for the insight update rate limit allows the update rate to burst up to 50 times before stabilizing to the desired rate. This would typically happen when kuma-cp starts up and all the dataplanes reconnect, which is precisely the time when you want the rate limit to apply for operational stability. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 13df4cf)
Codecov Report
@@ Coverage Diff @@
## release-1.3 #2835 +/- ##
===============================================
+ Coverage 52.12% 52.14% +0.02%
===============================================
Files 881 881
Lines 51232 51232
===============================================
+ Hits 26706 26717 +11
+ Misses 22407 22394 -13
- Partials 2119 2121 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2825 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/