Skip to content

Commit

Permalink
fix(kuma-cp) remove insight update rate limit burst (#2825) (#2835)
Browse files Browse the repository at this point in the history
The token burst that is configured for the insight update rate limit
allows the update rate to burst up to 50 times before stabilizing to the
desired rate. This would typically happen when kuma-cp starts up and all
the dataplanes reconnect, which is precisely the time when you want the
rate limit to apply for operational stability.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 13df4cf)

Co-authored-by: James Peach <james.peach@konghq.com>
  • Loading branch information
mergify[bot] and jpeach authored Sep 25, 2021
1 parent 723452f commit 7977acc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/insights/components.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ func Setup(rt runtime.Runtime) error {
MinResyncTimeout: rt.Config().Metrics.Mesh.MinResyncTimeout,
MaxResyncTimeout: rt.Config().Metrics.Mesh.MaxResyncTimeout,
RateLimiterFactory: func() *rate.Limiter {
return rate.NewLimiter(rate.Every(rt.Config().Metrics.Mesh.MinResyncTimeout), 50)
return rate.NewLimiter(rate.Every(rt.Config().Metrics.Mesh.MinResyncTimeout), 0)
},
Registry: registry.Global(),
})
Expand Down

0 comments on commit 7977acc

Please sign in to comment.