chore(k8s) Use a single scheme for all of k8s (backport #2796) #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* chore(k8s) Use a single scheme for all of k8s We were modifying the same scheme in many places when configuring the controllers. This is unecessary and is likely to introduce bugs. We now use the same scheme for everything and modify it at initialization Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit fdc5f1a)
|
@Mergifyio update |
|
Command
|
…release-1.3/pr-2796
Codecov Report
@@ Coverage Diff @@
## release-1.3 #2812 +/- ##
===============================================
+ Coverage 52.10% 52.16% +0.06%
===============================================
Files 880 881 +1
Lines 51253 51232 -21
===============================================
+ Hits 26707 26727 +20
+ Misses 22426 22380 -46
- Partials 2120 2125 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2796 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/