chore(k8s) Use a single scheme for all of k8s #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #2764 |
lahabana
force-pushed
the
schemaSimplification
branch
from
4ee6a30 to
ecba9f2
Compare
Codecov Report
@@ Coverage Diff @@
## master #2796 +/- ##
==========================================
+ Coverage 52.00% 52.09% +0.08%
==========================================
Files 881 882 +1
Lines 51341 51320 -21
==========================================
+ Hits 26700 26734 +34
+ Misses 22525 22460 -65
- Partials 2116 2126 +10
Continue to review full report at Codecov.
|
jpeach
reviewed
Sep 20, 2021
lahabana
force-pushed
the
schemaSimplification
branch
from
abb924e to
00ba8c6
Compare
|
@Mergifyio update |
|
Command
|
jakubdyszkiewicz
approved these changes
Sep 21, 2021
We were modifying the same scheme in many places when configuring the controllers. This is unecessary and is likely to introduce bugs. We now use the same scheme for everything and modify it at initialization Signed-off-by: Charly Molter <charly.molter@konghq.com>
Co-authored-by: James Peach <jpeach@apache.org> Signed-off-by: Charly Molter <charly.molter@konghq.com>
lahabana
force-pushed
the
schemaSimplification
branch
from
3f8f469 to
5b4733d
Compare
mergify bot
pushed a commit
that referenced
this pull request
Sep 21, 2021
* chore(k8s) Use a single scheme for all of k8s We were modifying the same scheme in many places when configuring the controllers. This is unecessary and is likely to introduce bugs. We now use the same scheme for everything and modify it at initialization Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit fdc5f1a)
lahabana
added a commit
that referenced
this pull request
Sep 22, 2021
We were modifying the same scheme in many places when configuring the controllers. This is unecessary and is likely to introduce bugs. We now use the same scheme for everything and modify it at initialization Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit fdc5f1a) Co-authored-by: Charly Molter <charly.molter@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
* chore(k8s) Use a single scheme for all of k8s We were modifying the same scheme in many places when configuring the controllers. This is unecessary and is likely to introduce bugs. We now use the same scheme for everything and modify it at initialization Signed-off-by: Charly Molter <charly.molter@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
* chore(k8s) Use a single scheme for all of k8s We were modifying the same scheme in many places when configuring the controllers. This is unecessary and is likely to introduce bugs. We now use the same scheme for everything and modify it at initialization Signed-off-by: Charly Molter <charly.molter@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were modifying the same scheme in many places when configuring the
controllers. This is unecessary and is likely to introduce bugs.
We now use the same scheme for everything and modify it at initialization
Documentation
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.