-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(policy-summary): add spec to structured view #3579
feat(policy-summary): add spec to structured view #3579
Conversation
Signed-off-by: schogges <moritz.fleck@konghq.com>
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I had one tiny suggestion, and a non-important curiosity question. Otherwise I reckon this is good to go! lmk on those
packages/kuma-gui/src/app/policies/components/PolicySummary.vue
Outdated
Show resolved
Hide resolved
Oh wait, I think this depends on a topLevel targetRef, so I think the screengrab I posted here is correct? |
We fall back to |
Signed-off-by: schogges <moritz.fleck@konghq.com>
This is the first part and in a follow-up I'll add more view types for the config. Here I added the spec in a code block to the structured view, so the user can still get all information in this view and doesn't need to switch to YAML.
I added a prop to hide the
Copy as K8s
button from the code block. I think the spec is agnostic to universal and k8s.Part of #3489