Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more Info to Structured Format of Policy Summary View #3489

Open
schogges opened this issue Jan 29, 2025 · 2 comments · May be fixed by #3581
Open

Add more Info to Structured Format of Policy Summary View #3489

schogges opened this issue Jan 29, 2025 · 2 comments · May be fixed by #3581
Assignees
@schogges
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone
2.10.x

Comments

@schogges
Copy link
Contributor

schogges commented Jan 29, 2025 •
edited
Loading

Description

After we have split up the summary view into formats, the structured view is too blank in some cases, i.e. the policy summary view only shows a few fields and we can add some more info here. Users might be most interested in the spec entry.

Image
@schogges schogges added kind/feature New feature triage/pending This issue will be looked at on the next triage meeting labels Jan 29, 2025
@lahabana
Copy link
Contributor

Dropdowns should include "Universal YAML" and "Kubernetes YAML".

We should add the yaml of the spec (when there a "spec") inline in the Structured view.

@bartsmykla bartsmykla added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Feb 3, 2025
@lahabana lahabana added this to the 2.10.x milestone Feb 12, 2025
@lahabana lahabana mentioned this issue Feb 12, 2025
Closed
@schogges schogges self-assigned this Feb 19, 2025
@lahabana
Copy link
Contributor

2 steps:

  1. Add spec to policies structured view (as code block)
  2. Make the dropdown a 3 choice option (structured, kubernetes, universal)
  3. Remember in localstorage which is picked

This was referenced Feb 20, 2025
Merged
Open
schogges added a commit that referenced this issue Feb 24, 2025
@schogges
feat(policy-summary): add spec to structured view (#3579)
e614095 
This is the first part and in a follow-up I'll add more view types for
the config. Here I added the spec in a code block to the structured
view, so the user can still get all information in this view and doesn't
need to switch to YAML.

---

I added a prop to hide the `Copy as K8s` button from the code block. I
think the spec is agnostic to universal and k8s.

---


![image](https://github.com/user-attachments/assets/d7449a69-911f-405f-9be5-2c3e844a1fd0)

Part of #3489

---------

Signed-off-by: schogges <moritz.fleck@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schogges schogges

Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
2.10.x
Development

Successfully merging a pull request may close this issue.

feat(policy-summary): add formats universal and kubernetes schogges/kuma-gui
3 participants
@lahabana @bartsmykla @schogges