-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(policy-summary): add formats universal and kubernetes #3581
base: master
Are you sure you want to change the base?
feat(policy-summary): add formats universal and kubernetes #3581
Conversation
Signed-off-by: schogges <moritz.fleck@konghq.com>
Signed-off-by: schogges <moritz.fleck@konghq.com>
Signed-off-by: schogges <moritz.fleck@konghq.com>
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think we are going to have to decide what to do about our "Global Format" values. Previous to this PR we had 2 possible values Off the back of that I have a question, with some potential follow up questions/suggestions.
Separately, I think we will have to build the data interaction so if you don't have Kubernetes selected when landing on the page we don't make the |
Hmmm, good point 🤔 I think we will have more options everywhere. I think that would be beneficial for the UX, because as a kubernetes user I'm mainly/only interested in the k8s format. But during the time where we have to support
I was thinking about this and thought it'd be better to load this initially than loading it after selecting k8s 🤔 but I can move the |
👍 cool
Yeah this is where things can get weird. global could be on k8s, but a zone on that install could be universal or vice-versa. Or maybe I just want to see what universal looks like even though I'm totally on k8s. Given the above maybe we should change the values to |
Yeah, totally agree 👍
Sounds good 👍 I'll change it, but would also like to ask wdyt we should do once we add JSON to the group? 🙂 |
The good thing is that in all the other places we currently have the flow of either show |
Signed-off-by: schogges <moritz.fleck@konghq.com>
Signed-off-by: schogges <moritz.fleck@konghq.com>
Hmm, depends, what will the content of the JSON be? I would guess we aren't doing "JSON Universal" and "JSON Kubernetes", but maybe we are? |
Signed-off-by: schogges <moritz.fleck@konghq.com>
Not sure either, I guess we'll find out then 😄 I could imagine that we'd show everything yaml as json additionally, but not too sure. |
I just realized another thing: we currently only show the select in case there is a |
…y-view Signed-off-by: schogges <moritz.fleck@konghq.com>
Signed-off-by: schogges <moritz.fleck@konghq.com>
Signed-off-by: schogges <moritz.fleck@konghq.com>
7e90e2c
to
207257e
Compare
Signed-off-by: schogges <moritz.fleck@konghq.com>
Signed-off-by: schogges <moritz.fleck@konghq.com>
Signed-off-by: schogges <moritz.fleck@konghq.com>
Requires
Splits the format
YAML
intoKubernetes
andUniversal
. The selected format is stored as preferencek8s
oruniversal
in local storage.Kubernetes
Universal
Closes #3489