[MTV-1801] [RFE] Non informative message

packages/forklift-console-plugin/src/modules/Plans/components/index.ts

@@ -1,5 +1,4 @@
 // @index(['./*', /style/g], f => `export * from '${f.path}';`)
-export * from './PlanCriticalConditions';
 export * from './PlansAddButton';
 export * from './PlansEmptyState';
 // @endindex

packages/forklift-console-plugin/src/modules/Plans/utils/types/PlanCondition.ts

@@ -0,0 +1,43 @@
+// Reference: https://github.com/kubev2v/forklift/blob/3113e867374c560ffbdcd34ef1627cb867893ba5/pkg/controller/plan/validation.go
+
+export enum PlanConditionType {
+  Ready = 'Ready',
+  NotReady = 'NotReady',
+  WarmMigrationNotReady = 'WarmMigrationNotReady',
+  NamespaceNotValid = 'NamespaceNotValid',
+  TransferNetNotValid = 'TransferNetworkNotValid',
+  NetRefNotValid = 'NetworkMapRefNotValid',
+  NetMapNotReady = 'NetworkMapNotReady',
+  DsMapNotReady = 'StorageMapNotReady',
+  DsRefNotValid = 'StorageRefNotValid',
+  VMRefNotValid = 'VMRefNotValid',
+  VMNotFound = 'VMNotFound',
+  VMAlreadyExists = 'VMAlreadyExists',
+  VMNetworksNotMapped = 'VMNetworksNotMapped',
+  VMStorageNotMapped = 'VMStorageNotMapped',
+  VMStorageNotSupported = 'VMStorageNotSupported',
+  VMMultiplePodNetworkMappings = 'VMMultiplePodNetworkMappings',
+  VMMissingGuestIPs = 'VMMissingGuestIPs',
+  VMMissingChangedBlockTracking = 'VMMissingChangedBlockTracking',
+  HostNotReady = 'HostNotReady',
+  DuplicateVM = 'DuplicateVM',
+  NameNotValid = 'TargetNameNotValid',
+  HookNotValid = 'HookNotValid',
+  HookNotReady = 'HookNotReady',
+  HookStepNotValid = 'HookStepNotValid',
+  Executing = 'Executing',
+  Succeeded = 'Succeeded',
+  Failed = 'Failed',
+  Canceled = 'Canceled',
+  Deleted = 'Deleted',
+  Paused = 'Paused',
+  Pending = 'Pending',
+  Running = 'Running',
+  Blocked = 'Blocked',
+  Archived = 'Archived',
+  unsupportedVersion = 'UnsupportedVersion',
+  VDDKInvalid = 'VDDKInvalid',
+  ValidatingVDDK = 'ValidatingVDDK',
+  VDDKInitImageNotReady = 'VDDKInitImageNotReady',
+  VDDKInitImageUnavailable = 'VDDKInitImageUnavailable',
+}

packages/forklift-console-plugin/src/modules/Plans/views/details/components/PlanCriticalCondition.tsx

@@ -1,19 +1,65 @@
-import React from 'react';
+import React, { ReactNode } from 'react';
 import { useTranslation } from 'react-i18next';
 import Linkify from 'react-linkify';
+import { useHistory } from 'react-router';
+import { PlanConditionType } from 'src/modules/Plans/utils/types/PlanCondition';
+import { getResourceUrl } from 'src/modules/Providers';
+import { ForkliftTrans } from 'src/utils';
 import { EMPTY_MSG } from 'src/utils/constants';
 
-import { Alert, AlertVariant, Text, TextContent, TextVariants } from '@patternfly/react-core';
+import { PlanModelRef, V1beta1Plan, V1beta1PlanStatusConditions } from '@kubev2v/types';
+import {
+  Alert,
+  AlertVariant,
+  Button,
+  Text,
+  TextContent,
+  TextVariants,
+} from '@patternfly/react-core';
 
-const PlanCriticalCondition: React.FC<{ type: string; message: string }> = ({ type, message }) => {
+type PlanCriticalConditionProps = {
+  plan: V1beta1Plan;
+  condition: V1beta1PlanStatusConditions;
+};
+
+const PlanCriticalCondition: React.FC<PlanCriticalConditionProps> = ({ plan, condition }) => {
   const { t } = useTranslation();
+  const history = useHistory();
+
+  const { type, message: conditionMessage } = condition;
+  let troubleshootMessage: ReactNode = t(
+    'To troubleshoot, check the Forklift controller pod logs.',
+  );
+
+  if (
+    type === PlanConditionType.VMNetworksNotMapped ||
+    type === PlanConditionType.VMStorageNotMapped ||
+    type === PlanConditionType.VMMultiplePodNetworkMappings
+  ) {
+    const planURL = getResourceUrl({
+      reference: PlanModelRef,
+      name: plan?.metadata?.name,
+      namespace: plan?.metadata?.namespace,
+    });
+
+    troubleshootMessage = (
+      <ForkliftTrans>
+        To troubleshoot, please check and edit your plan{' '}
+        <Button isInline variant="link" onClick={() => history.push(`${planURL}/mappings`)}>
+          mappings
+        </Button>
+        .
+      </ForkliftTrans>
+    );
+  }
+
   return (
     <Alert title={t('The plan is not ready') + ' - ' + type} variant={AlertVariant.danger}>
       <TextContent className="forklift-providers-list-header__alert">
         <Text component={TextVariants.p}>
-          <Linkify>{message || EMPTY_MSG}</Linkify>
-          {'. '}
-          {t('To troubleshoot, check the Forklift controller pod logs.')}
+          <Linkify>{conditionMessage || EMPTY_MSG}</Linkify>
+          {`${!conditionMessage.endsWith('.') ? '.' : ''} `}
+          {troubleshootMessage}
         </Text>
       </TextContent>
     </Alert>

packages/forklift-console-plugin/src/modules/Plans/views/details/components/PlanPageHeadings.tsx

@@ -86,8 +86,8 @@ export const PlanPageHeadings: React.FC<{ name: string; namespace: string }> = (
     if (criticalCondition) {
       alerts.push(
         <PlanCriticalCondition
-          type={criticalCondition?.type}
-          message={criticalCondition?.message}
+          plan={plan}
+          condition={criticalCondition}
           key={'providerCriticalCondition'}
         />,
       );