[MTV-1801] [RFE] Non informative message

[jpuzz0]

📝 Links

https://issues.redhat.com/browse/MTV-1801

📝 Description

Improve message to point users to the "Mappings" tab, indicating editing is required to solve specific Critical condition type error responses for plans.

The JIRA issue suggests including more information in the alert, and we can figure out which storage and network maps are missing, but that information is more readily available in the Mappings tab, and it seems like that is the best place to call those missing mappings out. How we do that exactly is a question for UXD, which can be a separate enhancement follow-up to this solution.

🎥 Demo

Screen.Recording.2025-02-05.at.2.47.57.PM.mov

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.32%. Comparing base (13484d0) to head (af24f7b).
Report is 218 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1462      +/-   ##
==========================================
- Coverage   36.81%   36.32%   -0.50%     
==========================================
  Files         158      156       -2     
  Lines        2548     2522      -26     
  Branches      599      588      -11     
==========================================
- Hits          938      916      -22     
- Misses       1428     1601     +173     
+ Partials      182        5     -177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metalice]

@jpuzz0 can tell the user exactly which mapping is missing? like SC name, network name

[jpuzz0]

@jpuzz0 can tell the user exactly which mapping is missing? like SC name, network name

@metalice
Yes, but this gets into design territory as there could be a large number of missing items in multiple categories, as mentioned, network mappings, along with what this story only called out, storage mappings.

So to display all of that information within an Alert might not be the way to go, especially since there needs to be a couple additional API requests to even determine those names. I think pointing users to the page where they can edit, where these requests are already being made, and using form errors would be more efficient and I can talk to the UXD folks about this more as a follow-up. (briefly mentioned this in the description of the PR)

[metalice]

@jpuzz0 can tell the user exactly which mapping is missing? like SC name, network name

@metalice Yes, but this gets into design territory as there could be a large number of missing items in multiple categories, as mentioned, network mappings, along with what this story only called out, storage mappings.

So to display all of that information within an Alert might not be the way to go, especially since there needs to be a couple additional API requests to even determine those names. I think pointing users to the page where they can edit, where these requests are already being made, and using form errors would be more efficient and I can talk to the UXD folks about this more as a follow-up. (briefly mentioned this in the description of the PR)

Can we add collapse into the alert? so it will be closed and hidden by default and expand if a user want to know more info?

[heyethankim]

The alert box should focus on what happened and why. The recovery process, including more details, should take place on the target page, which is the "Mappings" page.

@metalice This is the general rule. Since the plan can’t run due to this issue, don't users want to diagnose the problem within the page?

[heyethankim]

@metalice, thank you so much for sharing the CNV example. One thing we agreed on is to preserve the target page in the alert message, which is the Mappings page. Now it is really about determining if there’s any additional information we need to include in the alert message.

Could you help us to figure that out?

Just reviewed the Mappings page. There is a transition when users click on “Edit mappings.” I am wondering if, upon clicking “mappings” from the alert message, we can allow users to access the page to edit mappings directly, rather than adding more instructions. If we do, it is really just about adding or removing, correct?

I think we definitely need help from @wolfeallison with the inline alert messaging.