Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts basic data of forked extension. It also addresses kubeshop/vscode-monokle#16 by simply changing related settings defaults (still we need to switch to this fork as dep in Monokle extension itself).
I try to keep the changes minimal at this stage, but with time we can see how it works and which approach works best. It will be also good to contribute back to original extension with all generic bugfixes/improvements (all but Monokle dedicated).
One issue I see is that you can't have two extensions registering same commands / settings (considering full path). So I needed to update naming (see a0fed47) and so there is no conflict between original SARIF extension and our fork (having both, trying to register same commands, one will fail to initialize). This is an issue since the more changes we make the harder it will be to synchronize with new updates in original extension. But, that's what you get with forking - more freedom and more responsibility 😄
Changes
Fixes
Checklist