Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust fork repo setup #1

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Adjust fork repo setup #1

merged 6 commits into from
Nov 30, 2023

Conversation

f1ames
Copy link

@f1ames f1ames commented Nov 28, 2023

This PR adjusts basic data of forked extension. It also addresses kubeshop/vscode-monokle#16 by simply changing related settings defaults (still we need to switch to this fork as dep in Monokle extension itself).

I try to keep the changes minimal at this stage, but with time we can see how it works and which approach works best. It will be also good to contribute back to original extension with all generic bugfixes/improvements (all but Monokle dedicated).

One issue I see is that you can't have two extensions registering same commands / settings (considering full path). So I needed to update naming (see a0fed47) and so there is no conflict between original SARIF extension and our fork (having both, trying to register same commands, one will fail to initialize). This is an issue since the more changes we make the harder it will be to synchronize with new updates in original extension. But, that's what you get with forking - more freedom and more responsibility 😄

Changes

  • As above.

Fixes

  • As above.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@f1ames f1ames changed the title chore: adjust metadata chore: adjust basic data Nov 28, 2023
@f1ames f1ames changed the title chore: adjust basic data chore: adjust repo Nov 28, 2023
@f1ames f1ames requested a review from WitoDelnat November 29, 2023 09:18
@f1ames f1ames mentioned this pull request Nov 29, 2023
4 tasks
@f1ames f1ames changed the title chore: adjust repo Adjust fork repo setup Nov 29, 2023
@f1ames f1ames merged commit bdfdd60 into main Nov 30, 2023
3 checks passed
@f1ames f1ames deleted the f1ames/chore/fork branch November 30, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants