Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SARIF <> GitHub integration prompt #16

Closed
WitoDelnat opened this issue Jul 14, 2023 · 4 comments · Fixed by #60
Closed

Disable SARIF <> GitHub integration prompt #16

WitoDelnat opened this issue Jul 14, 2023 · 4 comments · Fixed by #60
Assignees
Labels
enhancement New feature or request external:sarif Requires changes in SARIF extension

Comments

@WitoDelnat
Copy link

WitoDelnat commented Jul 14, 2023

When you open a repo a popup appears bottom-right to connect to GitHub. Can we disable this somehow by default? Setting name is sarif-viewer.connectToGithubCodeScanning

@f1ames f1ames added the enhancement New feature or request label Jul 14, 2023
@f1ames
Copy link
Contributor

f1ames commented Jul 14, 2023

I think we can disable it (e.g. if it has no value set) on Monokle extension start with WorkspaceConfiguration API:

vscode.workspace.getConfiguration().update(...);

@f1ames f1ames added the external:sarif Requires changes in SARIF extension label Jul 17, 2023
@f1ames
Copy link
Contributor

f1ames commented Nov 2, 2023

Unfortunately, it became more annoying with recent SARIF plugin update which shows another pop-up for GitHub integration:

image

@f1ames
Copy link
Contributor

f1ames commented Nov 2, 2023

Unfortunately, it became more annoying with recent SARIF plugin update which shows another pop-up for GitHub integration:

image

Regarding the above, seems like it is connected with notification mentioned in initial description. No matter how I close it, this pop-up always appears (unless you pick Never). Seems like a bug to me TBH 🤔

monokle 20231102

Anyways, disabling initial notification (with e.g. this workaround - #16 (comment)) should fix this.

@f1ames f1ames assigned f1ames and unassigned f1ames Nov 15, 2023
@f1ames
Copy link
Contributor

f1ames commented Nov 15, 2023

Just as quick heads-up - to do it properly we will need to fork Sarif extension. As a workaround, Monokle extension can override Sarif ext setting as mentioned in #16 (comment), but this has some caveats:

  • It will result in changes in local .vscode/settings.json file which might be a bit confusing / not desired by users.
  • The sarif-viewer.connectToGithubCodeScanning takes effect only after VSC restart, so even when we disable it on the first run it still be visible on this first run (well, still better than for each run).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external:sarif Requires changes in SARIF extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants