Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Change paths of debug pages #38884

Merged
merged 2 commits into from
Jan 17, 2023
Merged

[ja] Change paths of debug pages #38884

merged 2 commits into from
Jan 17, 2023

Conversation

shogohida
Copy link
Contributor

Signed-off-by: Shogo Hida shogo.hida@gmail.com

Fixes #38797

This PR changes the paths of debug pages. The example shown on the issue is below.

  • Change path
    • e.g.: /ja/docs/tasks/debug-application-cluster/audit/ -> /ja/docs/tasks/debug/debug-cluster/audit/
      /ja/docs/tasks/debug-application-cluster

@shogohida
Change paths of debug pages
c3286b3 
Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 11, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: shogohida / name: Shogo Hida (c3286b3)

@k8s-ci-robot k8s-ci-robot requested review from atoato88 and ptux January 11, 2023 12:11
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 11, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @shogohida!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 11, 2023
@netlify
Copy link

netlify bot commented Jan 11, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ce164c0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63c14b7c2cbe5c000890e559
😎 Deploy Preview https://deploy-preview-38884--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

This was referenced Jan 11, 2023
Closed
Closed
atoato88
atoato88 reviewed Jan 13, 2023
View reviewed changes
Copy link
Contributor

@atoato88 atoato88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comment.

content/ja/docs/tasks/run-application/force-delete-stateful-set-pod.md Outdated Show resolved Hide resolved
@atoato88
Copy link
Contributor

First of all, thank you for creating this PR!
Almost all are OK for me.

But I grep "/debug-application-cluster/" on ja content and found other target files followings:

  1. ja/docs/concepts/cluster-administration/cluster-administration-overview.md
  2. ja/docs/concepts/cluster-administration/manage-deployment.md
  3. ja/docs/setup/production-environment/windows/intro-windows-in-kubernetes.md
  4. ja/docs/tasks/debug/debug-cluster/local-debugging.md

Files 1. to 3. have the link to "/debug-application-cluster/" and the URL has ja page. so we can update those, I think.

@t-inu
Last file 4. have also the link to "/debug-application-cluster/" but the URL doen't have ja page.
(And we should update task with tasks in URL on this page...)
What do we do about this?

@shogohida @t-inu
Or those files are out of scope on this PR?

@shogohida
Fix link
ce164c0 
Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
@shogohida
Copy link
Contributor Author

@atoato88
Thanks for reviewing my PR! I think the files you mentioned are out of the scope of this PR because the issue is based on debug files as the title says and I just changed paths which already have /ja.

The issue shows these 3 cases and I just took the second case for this PR. The requirement is to create each PR for each case.

  • Only add "/ja"
    • e.g.: /docs/tasks/debug/debug-cluster/audit/ -> /ja/docs/tasks/debug/debug-cluster/audit/
  • Change path
    • e.g.: /ja/docs/tasks/debug-application-cluster/audit/ -> /ja/docs/tasks/debug/debug-cluster/audit/
  • Change path and add "/ja"
    • e.g.: /docs/tasks/debug-application-cluster/resource-usage-monitoring/ -> /ja/docs/tasks/debug/debug-cluster/resource-usage-monitoring/

@atoato88
Copy link
Contributor

/lgtm

Thank you for quick update and detailed comment! 👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b2f9a3384f62c3ebe57736b4837137f78b65ca4d

@shogohida
Copy link
Contributor Author

Thanks for your quick review too!

t-inu
t-inu approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed and LGTM. Thanks!

@shogohida
Copy link
Contributor Author

@t-inu
Thanks for your review! I will solve other cases you mentioned in the issue after this PR!

@atoato88
Copy link
Contributor

/assign @nasa9084

@inductor
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor, t-inu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 284be91 into kubernetes:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoato88 atoato88 atoato88 left review comments

@t-inu t-inu t-inu approved these changes

@ptux ptux Awaiting requested review from ptux

Assignees

@atoato88 atoato88

@nasa9084 nasa9084

@inductor inductor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ja] Some links to debug page are outdated
6 participants
@shogohida @k8s-ci-robot @atoato88 @inductor @t-inu @nasa9084