Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invalid reference to cloud-controller-manager. #9888

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Remove invalid reference to cloud-controller-manager. #9888

merged 1 commit into from
Oct 22, 2018

Conversation

amwat
Copy link
Contributor

@amwat amwat commented Oct 22, 2018

Branch protector is failing on the cloud-controller-manager repo.
It was removed according to kubernetes/org#56 (comment)

/cc @spiffxp @fejta

@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 22, 2018
@spiffxp
Copy link
Member

spiffxp commented Oct 22, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2018
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bc1f0dff48928bf6a573e8b59df7e0fcdb91dcac

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6b7aa77 into kubernetes:master Oct 22, 2018
@k8s-ci-robot
Copy link
Contributor

@amwat: Updated the config configmap using the following files:

  • key config.yaml using file prow/config.yaml

In response to this:

Branch protector is failing on the cloud-controller-manager repo.
It was removed according to kubernetes/org#56 (comment)

/cc @spiffxp @fejta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@amwat amwat deleted the branchprotect branch October 23, 2018 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta Awaiting requested review from fejta

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amwat @spiffxp @k8s-ci-robot