-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REQUEST: Creation of KEP 14 repos #56
Comments
@sttts Has sig-arch approved of new core repos? Was there a meeting agenda item or a mailing list thread where they do? cc: @jdumars @bgrant0607 |
@cblecker the KEP was approved which proposed these repos. |
Looks like this is slated for discussion in sig-arch on Thursday |
/assign |
It's also unclear to me whether/where these repos should fall in sigs.yaml? |
New repos requested in: kubernetes/org#58 kubernetes/org#56 Change-Id: I2e71a998db2e53b8d8827a59a7b35198f52e3e13
https://github.com/kubernetes/kube-controller-manager |
@stewart-yu thanks for the correction. Yes, we keep those types in the cmd package because the future of the binary is not clear. |
@GeorgeGuo2018 I will update github.com/kubernetes/publishing-bot and it will fill that repo. Which "older projects" do you refer to? |
@spiffxp we have the OWNERS files in there. Isn't that enough? Listing those repos in sigs.yaml in addition sounds equivalent. |
@spiffxp as @stewart-yu correctly noted, cloud-controller-manager is not used. You can delete it again. |
New repos requested in: kubernetes/org#58 kubernetes/org#56 Change-Id: I2e71a998db2e53b8d8827a59a7b35198f52e3e13
New repos requested in: kubernetes/org#58 kubernetes/org#56 Change-Id: I2e71a998db2e53b8d8827a59a7b35198f52e3e13
@sttts every other repo that comes out of staging is listed in sigs.yaml as belonging to a sig, egs: sig-api-machinery has this entry
sig-architecture has this entry
I don't know if the intent is to move to a world where each component is owned by a different sig, eg:
or, if sig-archtecture owns the root of each component, with individual sigs owning packages within (eg: sig-architecture owns api, but sig-apps owns the workload apis) |
@spiffxp I wasn't aware that we link OWNERS files there. So of course the new repos belong into that file 👍 |
New repos requested in: kubernetes/org#58 kubernetes/org#56 Change-Id: I2e71a998db2e53b8d8827a59a7b35198f52e3e13
New repos requested in: kubernetes/org#58 kubernetes/org#56 Change-Id: I2e71a998db2e53b8d8827a59a7b35198f52e3e13
Current status:
|
I chatted with @sttts offline, the repo descriptions have been changed Just waiting for a sigs.yaml PR to close this out |
I don't know either whether we want the specialized SIG (e.g. node) to own all of the k8s.io/kubelet repo or if we want it to own e.g. |
Having sig-arch own root and specialized sigs own different packages was one of the suggestions I made above. I have no strong preference other than an option get chosen. I will ask the sig-arch mailing list |
So far I have received two responses, both of which seem to suggest the sig-arch root / sig-foo subdirs approach. |
The final piece of this was fixed with kubernetes/kubernetes#70453, closing |
@luxas: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
To implement KEP 14, we need a couple of repos.
New Repo
cloud-controller-managerWhich Organization should it reside
kubernetes
Note that these are "staging repositories", i.e. they are published by the https://github.com/kubernetes/publishing-bot and therefore must be in the
kubernetes
org.Who should be provided access to this repository
We need admin access for the
stage-bots
team, compare:We need branch settings like:
Approvals
KEP 14: https://github.com/kubernetes/community/blob/master/keps/sig-cluster-lifecycle/0014-20180707-componentconfig-api-types-to-staging.md
Additional context for request
The staging repositories have been created in the staging/ directory of the k/k repo, all approved by top-level approvers @jbeda and @thockin.
/cc @luxas @stewart-yu
The text was updated successfully, but these errors were encountered: