more bash fun

[BenTheElder]

#8525 (comment)

8525 did fix the string comparison, but the check for if the variable was set did not work correctly... see: #8516 (comment)

/shrug
/area bash_fire

[BenTheElder]

oh hmm pull-test-infra-lint shouldn't be running on :latest-experimental image tag either...

[BenTheElder]

/test pull-test-infra-lint

[BenTheElder]

hacked the kubekins-e2e image to pull this down for now so I can move forward with testing

$ git diff
diff --git a/images/kubekins-e2e/Dockerfile b/images/kubekins-e2e/Dockerfile
index c88cc1ff8..221c5f2f5 100644
--- a/images/kubekins-e2e/Dockerfile
+++ b/images/kubekins-e2e/Dockerfile
@@ -76,3 +76,4 @@ ADD ["e2e-runner.sh", \
     "https://raw.githubusercontent.com/kubernetes/kubernetes/master/cluster/get-kube.sh", \
     "/workspace/"]
 RUN ["chmod", "+x", "/workspace/get-kube.sh"]
+RUN sed -i 's#kubernetes/test-infra#BenTheElder/test-infra \&\& cd ./test-infra \&\& git checkout bash_fire \&\& cd ./..#' /workspace/runner
diff --git a/images/kubekins-e2e/Makefile b/images/kubekins-e2e/Makefile
index c872bd346..70ae44ce6 100644
--- a/images/kubekins-e2e/Makefile
+++ b/images/kubekins-e2e/Makefile
@@ -24,7 +24,7 @@ CFSSL ?= R1.2
 # config for testing prior to rolling out to master / ongoing release
 ifeq ($(K8S), experimental)
        GO = 1.10.2
-       BAZEL = 0.14.0
+       BAZEL = 0.15.0
        CFSSL = R1.2
 endif

$ make -C images/kubekins-e2e push K8S=experimental
... <snipped lots of output here> ....
Pushed gcr.io/k8s-testimages/kubekins-e2e with :latest-experimental and :v20180630-1be44ad7f-dirty-experimental tags

[BenTheElder]

/test pull-test-infra-bazel-canary
/test pull-test-infra-lint

[BenTheElder]

/test pull-test-infra-bazel-canary
/test pull-test-infra-lint

[BenTheElder]

[verifying max_connections fix]
/test pull-test-infra-bazel-canary
/test pull-test-infra-lint

[BenTheElder]

[verifying max_connections fix]
/test pull-test-infra-bazel-canary
/test pull-test-infra-lint

[cblecker]

/lgtm
/hold

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [BenTheElder]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[BenTheElder]

/hold cancel