Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix version check in create_bazel_cache_rcs.sh #8525

Merged
merged 1 commit into from
Jun 30, 2018
Merged

fix version check in create_bazel_cache_rcs.sh #8525

merged 1 commit into from
Jun 30, 2018

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Jun 30, 2018 •
edited
Loading

-eq is for integers, = is for strings 🤦‍♂️

xref: #8516

@BenTheElder BenTheElder requested a review from krzyzacy as a code owner June 30, 2018 18:36
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 30, 2018
@BenTheElder BenTheElder mentioned this pull request Jun 30, 2018
Merged
@BenTheElder
Copy link
Member Author

I'll temporarily point the kubekins-e2e experimental-latest image at this branch.

@cblecker
Copy link
Member

/lgtm
/hold

:bash_fire:

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member Author

/hold cancel
/shrug

@k8s-ci-robot k8s-ci-robot added ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 30, 2018
@k8s-ci-robot k8s-ci-robot merged commit 1be44ad into kubernetes:master Jun 30, 2018
@BenTheElder
Copy link
Member Author

oh fantastic, still not right. (the string compare is, the check for the env isn't)... #8516 (comment)

@BenTheElder BenTheElder deleted the strings-not-integers branch June 30, 2018 18:57
@BenTheElder
Copy link
Member Author

:bash_fire:

@BenTheElder BenTheElder mentioned this pull request Jun 30, 2018
Merged
@BenTheElder BenTheElder added the area/greenhouse Issues or PRs related to code in /greenhouse (our remote bazel cache) label Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/greenhouse Issues or PRs related to code in /greenhouse (our remote bazel cache) cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @cblecker @k8s-ci-robot