Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old Prow image pushing job. #33212

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

michelle192837
Copy link
Contributor

@michelle192837 michelle192837 commented Aug 3, 2024

The new image pushing job has been running successfully for a few months and publishes images to a new location (post-k8s-infra-prow-images, to us-docker.pkg.dev/k8s-infra-prow/images). There should be no use of these images remaining within the kubernetes org once blocking PRs are submitted, so this job should be fine to turn down.

Current uses (based on the images listed in https://github.com/kubernetes-sigs/prow/blob/main/.prow-images.yaml)

/hold

Blocked on #33210 and kubernetes/k8s.io#7120, hold until these are submitted and we wait to see if they cause issues.

Ref #32432

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/config Issues or PRs related to code in /config labels Aug 3, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and rjsadow August 3, 2024 00:44
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 3, 2024
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

I believe we can safely merge this now?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2024
@michelle192837
Copy link
Contributor Author

Believe so!

/hold cancel

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michelle192837
Copy link
Contributor Author

Oh right, rebase. Working on it!

@BenTheElder
Copy link
Member

needs rebase

The new image pushing job has been running successfully for a few months
and publishes images to a new location (`post-k8s-infra-prow-images`, to
us-docker.pkg.dev/k8s-infra-prow/images). There should be no use of
these images remaining within the kubernetes org once blocking PRs are
submitted, so this job should be fine to turn down.
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 5, 2024
@BenTheElder
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit bad9aae into kubernetes:master Aug 5, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@michelle192837: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key prow-postsubmits.yaml using file config/jobs/kubernetes-sigs/prow/prow-postsubmits.yaml

In response to this:

The new image pushing job has been running successfully for a few months and publishes images to a new location (post-k8s-infra-prow-images, to us-docker.pkg.dev/k8s-infra-prow/images). There should be no use of these images remaining within the kubernetes org once blocking PRs are submitted, so this job should be fine to turn down.

Current uses (based on the images listed in https://github.com/kubernetes-sigs/prow/blob/main/.prow-images.yaml)

/hold

Blocked on #33210 and kubernetes/k8s.io#7120, hold until these are submitted and we wait to see if they cause issues.

Ref #32432

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@michelle192837 michelle192837 deleted the deleteprowimage branch August 5, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants