-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old Prow image pushing job. #33212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
I believe we can safely merge this now?
Believe so! /hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, michelle192837 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Oh right, rebase. Working on it! |
needs rebase |
The new image pushing job has been running successfully for a few months and publishes images to a new location (`post-k8s-infra-prow-images`, to us-docker.pkg.dev/k8s-infra-prow/images). There should be no use of these images remaining within the kubernetes org once blocking PRs are submitted, so this job should be fine to turn down.
1d5b0d0
to
dd12c63
Compare
/lgtm |
@michelle192837: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The new image pushing job has been running successfully for a few months and publishes images to a new location (
post-k8s-infra-prow-images
, to us-docker.pkg.dev/k8s-infra-prow/images). There should be no use of these images remaining within the kubernetes org once blocking PRs are submitted, so this job should be fine to turn down.Current uses (based on the images listed in https://github.com/kubernetes-sigs/prow/blob/main/.prow-images.yaml)
/hold
Blocked on #33210 and kubernetes/k8s.io#7120, hold until these are submitted and we wait to see if they cause issues.
Ref #32432