Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new location for Prow images instead of old. #33210

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

michelle192837
Copy link
Contributor

Prow images have been published to a new location for a while now (us-docker.pkg.dev/k8s-infra-prow/images/). These should be the same images as published to the old location, so update images to pull from the new location instead.

Also updated a couple of spots that reference the old gcr.io/k8s-prow location (in the README.md and the Makefile).

Ref #32432

Prow images have been published to a new location for a while now
(us-docker.pkg.dev/k8s-infra-prow/images/). These should be the same
images as published to the old location, so update images to pull from
the new location instead.

Also updated a couple of spots that reference the old gcr.io/k8s-prow
location (in the README.md and the Makefile).
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 3, 2024
@k8s-ci-robot k8s-ci-robot requested a review from aojea August 3, 2024 00:18
@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Aug 3, 2024
@k8s-ci-robot k8s-ci-robot requested a review from chases2 August 3, 2024 00:18
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/jobs area/prow/bump Updates to the k8s prow cluster sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 3, 2024
@michelle192837
Copy link
Contributor Author

/hold

Until Monday.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chases2, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michelle192837
Copy link
Contributor Author

/hold cancel

I'll keep an eye on the autobump later to make sure it picks up the changes correctly.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit b9f3762 into kubernetes:master Aug 5, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@michelle192837: Updated the following 2 configmaps:

  • job-config configmap in namespace default at cluster test-infra-trusted using the following files:
    • key sig-k8s-infra-prow.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-k8s-infra-prow.yaml
    • key sig-k8s-infra-test-infra.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-k8s-infra-test-infra.yaml
    • key sig-testing-branchprotector.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-testing-branchprotector.yaml
    • key test-infra-checkconfig.yaml using file config/jobs/kubernetes/test-infra/test-infra-checkconfig.yaml
    • key test-infra-presubmits.yaml using file config/jobs/kubernetes/test-infra/test-infra-presubmits.yaml
    • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml
  • config configmap in namespace default at cluster test-infra-trusted using the following files:
    • key config.yaml using file config/prow/config.yaml

In response to this:

Prow images have been published to a new location for a while now (us-docker.pkg.dev/k8s-infra-prow/images/). These should be the same images as published to the old location, so update images to pull from the new location instead.

Also updated a couple of spots that reference the old gcr.io/k8s-prow location (in the README.md and the Makefile).

Ref #32432

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

howardjohn added a commit to howardjohn/test-infra that referenced this pull request Aug 6, 2024
howardjohn added a commit to howardjohn/test-infra that referenced this pull request Aug 6, 2024
istio-testing pushed a commit to istio/test-infra that referenced this pull request Aug 7, 2024
howardjohn added a commit to howardjohn/test-infra that referenced this pull request Sep 24, 2024
istio-testing pushed a commit to istio/test-infra that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/prow/bump Updates to the k8s prow cluster cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants