Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workload identity token to be used with MI #32696

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

jsturtevant
Copy link
Contributor

This is a follow up to kubernetes-sigs/windows-testing#430 to prepare in removal of the Azure SP in prow. It follows the pattern in

.

It will require updates to the scripts in https://github.com/kubernetes-sigs/windows-testing to use this token that is generated and should not affect existing runs on this pr job.

/sig windows
/assign @marosset

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 31, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 31, 2024
@marosset
Copy link
Contributor

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2024
…-presubmits.yaml

Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@marosset
Copy link
Contributor

marosset commented Jun 3, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 57f7579 into kubernetes:master Jun 3, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@jsturtevant: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key release-master-windows-presubmits.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-master-windows-presubmits.yaml

In response to this:

This is a follow up to kubernetes-sigs/windows-testing#430 to prepare in removal of the Azure SP in prow. It follows the pattern in

.

It will require updates to the scripts in https://github.com/kubernetes-sigs/windows-testing to use this token that is generated and should not affect existing runs on this pr job.

/sig windows
/assign @marosset

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants