Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to use workload identity with Azure cli #439

Closed
wants to merge 2 commits into from
Closed

Add ability to use workload identity with Azure cli #439

wants to merge 2 commits into from

Conversation

jsturtevant
Copy link
Contributor

@jsturtevant jsturtevant commented Jun 7, 2024 •
edited
Loading

This uses a SP with no secret. It is configured to use the workload Identity from PROW jobs which was configured and exposed in kubernetes/test-infra#32696.

image

issuer: https://container.googleapis.com/v1/projects/k8s-prow-builds/locations/us-central1-f/clusters/prow
Service account: prowjob-default-sa
namespace: test-pods

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 7, 2024
@jsturtevant
Copy link
Contributor Author

/test all

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 7, 2024
@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

1 similar comment
@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

11 similar comments
@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

@jsturtevant
Add ability to use workload identity
9d78276 
if the value and token are present it will login into azure using the
id given.

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 14, 2024
@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

@jsturtevant jsturtevant changed the title add some test comamnds Add ability to use workload identity Jun 14, 2024
@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

@jsturtevant
Be explicit on namespace for cloud-provider
b55c971 
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 17, 2024
@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

@jsturtevant jsturtevant marked this pull request as ready for review June 20, 2024 17:53
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2024
@jsturtevant jsturtevant changed the title Add ability to use workload identity Add ability to use workload identity with Azure cli Jun 20, 2024
@jsturtevant
Copy link
Contributor Author

/hold

CAPZ is going to make a few updates to the scripts that we use so we can streamline the login process.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2024
@jsturtevant
Copy link
Contributor Author

xref: kubernetes-sigs/cluster-api-provider-azure#4939

@marosset
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension

1 similar comment
@marosset
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/close
in favor of moving to community sub #444

@k8s-ci-robot
Copy link
Contributor

@jsturtevant: Closed this PR.

In response to this:

/close
in favor of moving to community sub #444

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiubelu claudiubelu Awaiting requested review from claudiubelu

@jayunit100 jayunit100 Awaiting requested review from jayunit100

@adelina-t adelina-t Awaiting requested review from adelina-t

@marosset marosset Awaiting requested review from marosset

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsturtevant @k8s-ci-robot @marosset